Feeling Lucky
PR-5.3-dev
[#44295] - [5.3] Add missing MVCFactoryInterface into model constructors
- Fixed in Code Base
- 9 Nov 2024
- Medium
- Build: 5.2-dev
- # 44295
- Diff
- Denitz:patch52/missing-factory-in-models
User tests: Successful: Unsuccessful:
Summary of Changes
There are models which don't unitilize the MVCFactoryInterface $factory constructor argument for calling parent's constructor.
This results to useless extra calls to Factory::getApplication()->bootComponent() in BaseDatabaseModel::__construct.
Testing Instructions
Apply patch, ensure no errors on actions with patched models.
Actual result BEFORE applying this Pull Request
Model constructors are missing MVCFactoryInterface $factory argument.
Expected result AFTER applying this Pull Request
All good.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_cache com_contact com_content com_modules com_workflow Front End |
| Labels |
Added:
PR-5.2-dev
|
||
| Category | Administration com_banners com_cache com_contact com_content com_modules com_workflow Front End | ⇒ | Administration com_banners com_cache com_contact com_content com_modules com_workflow Front End Libraries |
| Labels |
Added:
PR-5.3-dev
|
||
| Title |
|
||||||
laoneo
- comment
- 26 Oct 2024
Can you fix the conflict here?
| Labels |
Removed:
PR-5.2-dev
|
||
| Category | Administration com_banners com_cache com_contact com_content com_modules com_workflow Front End Libraries | ⇒ | Administration com_banners com_cache com_contact com_content com_modules com_workflow Front End |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-09 15:15:40 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 9 Nov 2024
Thanks!
Looks good to me, but I would make this for 5.3 and not for 5.2. Would give us some more time to test and be sure we don't have unexpected side effects.