[#44222] - [J5.2] Cassiopeia - Only add margin to system message container if it contains a joomla-alert
- Fixed in Code Base
- 26 Oct 2024
- Medium
- Build: 5.2-dev
- # 44222
- Diff
- coolcat-creations:5.2-dev-fix-alert-margin
User tests: Successful: Unsuccessful:
Pull Request for Issue #40639.
Summary of Changes
Added a :has rule to control the margin of the system-message-container if it does not contain a tag
:has selector is supported by all modern browsers
Testing Instructions
login with wrong credentials in your cassiopeia frontend.
A system message appears that the login data is wrong
Click the close button to hide the message
Actual result BEFORE applying this Pull Request
After hiding a system alert, a margin of 1rem remains
Expected result AFTER applying this Pull Request
After hiding a system alert, the margin is not present anymore
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[x ] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[x ] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
I have tested this item ✅ successfully on 97d0209
with NPM Package
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.
I have tested this item ✅ successfully on 97d0209
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-26 16:03:43 |
| Closed_By | ⇒ | pe7er |
Thanks @coolcat-creations !
Thank you for merging!
I have tested this item ✅ successfully on 97d0209
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.