[#44221] - [J5.2] Fixing Cassiopeia mobile menu collapse bug #44140
- Pending
- Medium
- Build: 5.2-dev
- # 44221
- Diff
- coolcat-creations:5.2-dev-cassiopeia-dropdownfix
User tests: Successful: Unsuccessful:
Pull Request for Issue #44140 .
Summary of Changes
Took the code advise from @dgrammatiko inside the issue and tested working
Testing Instructions
Follow the error description from #44140 in Chrome
Actual result BEFORE applying this Pull Request
Submenus stop expanding
Expected result AFTER applying this Pull Request
Submenus stay at their last state and are still operable
Thank you @dgrammatiko for the fix!
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[x ] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[x ] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
@richard67 Its a mistake, I made a npm update and that happened then, how can I revert this?
@richard67 Its a mistake, I made a npm update and that happened then, how can I revert this?
@coolcat-creations Revert what? The npm update? Or the changed "package-lock.json" in this PR?
Where did the npm update happen? Only on the branch or this PR? Or on your 5.2-dev branch?
If it's only the branch of this PR, the easiest way is to close the PR and delete the branch of this PR, create a new branch with a different branch name and then use that new branch to redo your change in a new PR.
I made the npm update and apparently this created the changed package-lock — can we just revert this one file somehow?
I made the npm update and apparently this created the changed package-lock — can we just revert this one file somehow?
@coolcat-creations Sure. But as I don't know which Git client you are using, or which IDE, I can't advise how to do that, and explaining how to do it with the command line and a git command would be too long now. Alternatively you could take the file from a clean 5.2-dev branch, put it into your branch for this PR and commit and push the change. Then check on GitHub if the file is still shown among the changed files. It should not be shown anymore when that was done right.
Just copy the contents from the GitHub https://github.com/joomla/joomla-cms/blob/5.2-dev/package-lock.json and push it on your repo
@coolcat-creations This PR updates some NPM dependencies. See the changes in file "package-lock.json" showsn on GitHub (if you expand the changes). Is that by purpose, or is it a mistake?