[#44223] - [J5.3] Add an option to Cassiopeia to remove padding in horizontal menu
- Closed
- 17 Oct 2024
- Medium
- Build: 5.3-dev
- # 44223
- Diff
- coolcat-creations:5.3-dev-cassiopeia-menu
User tests: Successful: Unsuccessful:
Pull Request for Issue #37902.
Cassiopeia template Logo and menu alignment #37902
Summary of Changes
Added an Option in Cassiopeia Settings to remove the horizontal padding in the menu
If set to yes a class is added into the header
The class is set in metismenu scss to remove the left padding from the first item and the right padding from the last item
Testing Instructions
In Template Styles of Cassiopeia, set this option to yes
Logo should be left aligned with the menu
Set the Option to no
Logo is aligned with the ul List
Actual result BEFORE applying this Pull Request
Before the patch there is only the option to align to the ul list
Expected result AFTER applying this Pull Request
Like other templates already have this, I added an additional option to remove the left and right padding.
Link to documentations
Please select:
-
[ x] Documentation link for docs.joomla.org:
Can someone tell me where to send the documentation to? -
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[ x] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change Language & Strings Front End Templates (site) |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.3-dev
|
||
Please always use logical css properties so that the css is independent of LTR or RTL settings - suggested changes commented inline
Thank you all! Committed your change suggestions
Thanks for the suggestion, this PR has been added to the agenda of the next maintainers meeting. So far all responses to the idea are not in favor of it. Before spending more time on this PR wait till next week, when we have made a decision.
Ok, I saw such a setting it in a lot of templates. Maybe I can add to the discussion that the Cassiopeia template is far from being attractive to the users. So if this change does not get accepted, possibly there should be a plan for a new Frontend template in J6 - because this one is really not flexible for the user.
I have tested this item ✅ successfully on 2c5227f
I wanted to give DPDocker a try. Obviously very easy to test PRs (especially with NPM change where a simple local installation of Joomla is not enough)
joomla-pr/run-joomla-pr-webserver.sh 44223 -db mysql -php 8.1 would do everything for me :)
So I tested this successfully txs to DPDocker...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44223.
So if this change does not get accepted, possibly there should be a plan for a new Frontend template in J6 - because this one is really not flexible for the user.
We are thinking about this too.
Can this not be a achieved by the user creating an user.css file with the relevant classes?
For me the default Joomla Template should be as easy as possible for beginners to get them on Board with Joomla. The more you can do with UI the better. When I teach Kids about Joomla I want then to have a decent result after 3 days of learning. And they start from 0. So no, for me "Write your own css" is not a Solution, because then I would not use Cassiopeia anyway.
I have tested this item ✅ successfully on 2c5227f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44223.
For me the default Joomla Template should be as easy as possible for beginners to get them on Board with Joomla. The more you can do with UI the better. When I teach Kids about Joomla I want then to have a decent result after 3 days of learning. And they start from 0. So no, for me "Write your own css" is not a Solution, because then I would not use Cassiopeia anyway.
But you can not have an option for every little thing. That just makes everything way too complex. Especially as with this PR when it would only apply to a subset of users of cassiopeia
Whatever - I think yes every tiny thing should have an option so that beginners are happy with their site. Everyone else would use another template anyway
That just makes everything way too complex
@brianteeman It depends … diving in css-source-code or override-php-files is for other (like me) way too complex then click on an option.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-17 11:08:28 |
| Closed_By | ⇒ | rdeutz |
We have discussed it in our meeting and we don't want to go that route. I am sorry.
We have discussed it in our meeting and we don't want to go that route. I am sorry.
I'm not sorry because i don't know which meeting is meant and don't know the reasons for the decision.
I have tested this item ✅ successfully on 3076e5b
Test using English and Farsi.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44223.