[#44194] - [5.2] phpcs comments / use statements
- Fixed in Code Base
- 20 Oct 2024
- Medium
- Build: 5.2-dev
- # 44194
- Diff
- heelc29:5.2/phpcs-jexec
User tests: Successful: Unsuccessful:
Summary of Changes
- move use statements out of phpcs disable area
- fix phpcs:enable identifier
Testing Instructions
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Libraries |
I have tested this item ✅ successfully on 0c6ea05
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44194.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.2-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44194.
are we sure we even need to disable phpcs for this? There are a lot of instances where it is not disabled
eg
are we sure we even need to disable phpcs for this? There are a lot of instances where it is not disabled
@brianteeman It is needed when in that file a function is defined or a class. PHPCS say then that you shall not have both in the same file, a statement with side effects like the defined, and definition of a symbol.
In your example it is not needed because the function definitions are wrapped into an anonymous class.
@richard67 Thanks you for the explanation
| Labels |
Added:
RTC
|
||
pe7er
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-20 16:28:43 |
| Closed_By | ⇒ | pe7er |
I have tested this item ✅ successfully on 0c6ea05
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44194.