RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
6 Oct 2024

Summary of Changes

replace check of constant from JPATH_BASE to _JEXEC for restricted access
like other files eg.

// phpcs:disable PSR1.Files.SideEffects
\defined('_JEXEC') or die;
// phpcs:enable PSR1.Files.SideEffects

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

JPATH_BASE is used for check of restricted access

Expected result AFTER applying this Pull Request

JPATH_BASE is not used for check of restricted access

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 6 Oct 2024
avatar heelc29 heelc29 - change - 6 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2024
Category Installation
avatar Quy Quy - test_item - 6 Oct 2024 - Tested successfully
avatar Quy
Quy - comment - 6 Oct 2024

I have tested this item ✅ successfully on b8a737b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44193.

avatar richard67 richard67 - test_item - 6 Oct 2024 - Tested successfully
avatar richard67
richard67 - comment - 6 Oct 2024

I have tested this item ✅ successfully on b8a737b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44193.

avatar richard67 richard67 - change - 6 Oct 2024
Status Pending Ready to Commit
Labels Added: PR-4.4-dev
avatar richard67
richard67 - comment - 6 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44193.

avatar heelc29 heelc29 - change - 16 Oct 2024
Title
[4.4] use _JEXEC for restricted access
[5.2] use _JEXEC for restricted access
avatar heelc29 heelc29 - edited - 16 Oct 2024
avatar heelc29 heelc29 - change - 16 Oct 2024
Labels Added: RTC PR-5.2-dev
avatar heelc29
heelc29 - comment - 16 Oct 2024

Rebased to 5.2-dev

avatar Quy Quy - change - 16 Oct 2024
Labels Removed: PR-4.4-dev
avatar pe7er pe7er - change - 20 Oct 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-20 12:22:16
Closed_By pe7er
avatar pe7er pe7er - close - 20 Oct 2024
avatar pe7er pe7er - merge - 20 Oct 2024
avatar pe7er
pe7er - comment - 20 Oct 2024

Thanks @heelc29 !

Add a Comment

Login with GitHub to post a comment