RTC bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
5 Oct 2024

Pull Request for Issue #44054

Summary of Changes

load lang file

Testing Instructions

Have a user confirm acceptance of the Privacy Policy on login (Enable the System - Privacy Consent plugin)
Go to the administrator Privacy / Consents page.

Actual result BEFORE applying this Pull Request

The Subject is a string key: PLG_SYSTEM_PRIVACYCONSENT_SUBJECT

Expected result AFTER applying this Pull Request

the Subject is a translated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 5 Oct 2024
avatar alikon alikon - change - 5 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2024
Category Administration
avatar Kostelano Kostelano - test_item - 5 Oct 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 5 Oct 2024

I have tested this item ✅ successfully on 7bd6402


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192.

avatar ceford ceford - test_item - 5 Oct 2024 - Tested successfully
avatar ceford
ceford - comment - 5 Oct 2024

I have tested this item ✅ successfully on 7bd6402

Good - I see the the Subject change from a key to the translated string.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192.

avatar alikon alikon - change - 5 Oct 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 5 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192.

avatar richard67
richard67 - comment - 5 Oct 2024

@alikon Why for the 5.1-dev branch? There will not be any new 5.1 release. The PR should be made for the 5.2-dev branch. Could you rebase?

avatar alikon
alikon - comment - 5 Oct 2024

didn't know

avatar alikon alikon - change - 5 Oct 2024
Labels Added: RTC PR-5.1-dev
avatar richard67
richard67 - comment - 5 Oct 2024
avatar richard67
richard67 - comment - 5 Oct 2024

I think it doesn’t need new test and RTC is still ok as the rebase from 5.1-dev to 5.2-dev was clean without any conflicts.

avatar richard67 richard67 - change - 7 Oct 2024
Labels Added: bug PR-5.2-dev
Removed: PR-5.1-dev
avatar pe7er pe7er - change - 16 Oct 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-16 18:14:21
Closed_By pe7er
avatar pe7er pe7er - close - 16 Oct 2024
avatar pe7er pe7er - merge - 16 Oct 2024
avatar pe7er
pe7er - comment - 18 Oct 2024

Thanks @alikon !

Add a Comment

Login with GitHub to post a comment