RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
6 Oct 2024

Summary of Changes

#43814 use deprecated code
https://github.com/joomla-framework/application/blob/dd055642fbe8d7b919a6c6c345a0d016b0981e65/src/AbstractWebApplication.php#L229-L238

See also #39029 for information

Testing Instructions

  • use guided tours
  • code review

Actual result BEFORE applying this Pull Request

Use of deprecated access to the application's input property

Expected result AFTER applying this Pull Request

Application->getInput() instead of Application->input (no deprecation warning)

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 6 Oct 2024
avatar heelc29 heelc29 - change - 6 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2024
Category Administration
avatar richard67 richard67 - test_item - 6 Oct 2024 - Tested successfully
avatar richard67
richard67 - comment - 6 Oct 2024

I have tested this item ✅ successfully on b67e9c9

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44195.

avatar Quy Quy - test_item - 6 Oct 2024 - Tested successfully
avatar Quy
Quy - comment - 6 Oct 2024

I have tested this item ✅ successfully on b67e9c9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44195.

avatar richard67 richard67 - change - 6 Oct 2024
Status Pending Ready to Commit
Labels Added: PR-5.2-dev
avatar richard67
richard67 - comment - 6 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44195.

avatar Hackwar Hackwar - change - 7 Oct 2024
Labels Added: RTC
avatar Hackwar
Hackwar - comment - 7 Oct 2024

Thank you for your contribution @heelc29

avatar rdeutz rdeutz - change - 7 Oct 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-07 15:30:55
Closed_By rdeutz
avatar rdeutz rdeutz - close - 7 Oct 2024
avatar rdeutz rdeutz - merge - 7 Oct 2024

Add a Comment

Login with GitHub to post a comment