b/c break PR-6.0-dev PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
16 Sep 2024

Summary of Changes

Table::getInstance() has been deprecated some time ago and this PR removes most instances where this is used in the Joomla core.

Testing Instructions

Test that everything still works. Since this code is used nearly everywhere, there aren't really any more precise instructions.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 16 Sep 2024
avatar Hackwar Hackwar - change - 16 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Sep 2024
Category Administration com_admin com_associations com_banners com_categories com_config com_contact com_content com_contenthistory com_fields com_finder com_installer com_languages
avatar Hackwar Hackwar - change - 16 Sep 2024
Labels Added: PR-5.3-dev
avatar laoneo
laoneo - comment - 4 Oct 2024

Looks for me like a BC break as the getInstance function does a lookup in the container for instances.

avatar Hackwar
Hackwar - comment - 4 Oct 2024

You are right, I will convert this to 6.0-dev.

avatar Hackwar Hackwar - change - 4 Oct 2024
Title
[5.3] Remove instances of Table::getInstance() from core code
[6.0] Remove instances of Table::getInstance() from core code
avatar Hackwar Hackwar - edited - 4 Oct 2024
avatar Hackwar Hackwar - change - 4 Oct 2024
Labels Added: b/c break PR-6.0-dev

Add a Comment

Login with GitHub to post a comment