RTC PR-5.2-dev Guided Tours Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
16 Sep 2024

Summary of Changes

The 'delay' parameter is not filtered, allowing any character in the field.

Testing Instructions

Go to the Global Configuration of the Guided Tours.

Actual result BEFORE applying this Pull Request

Enter a value in the field 'Auto Start Time Delay (in minutes)'. Try entering letters.
You can set the field to any character other than numbers.

Expected result AFTER applying this Pull Request

You can no longer enter anything else but numbers.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar obuisard obuisard - open - 16 Sep 2024
avatar obuisard obuisard - change - 16 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Sep 2024
Category Administration
avatar brianteeman brianteeman - test_item - 16 Sep 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 16 Sep 2024

I have tested this item ✅ successfully on 78b9713


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091.

avatar obuisard obuisard - change - 16 Sep 2024
Labels Added: PR-5.2-dev Guided Tours
avatar Quy Quy - test_item - 16 Sep 2024 - Tested successfully
avatar Quy
Quy - comment - 16 Sep 2024

I have tested this item ✅ successfully on 00ac35d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091.

avatar tecpromotion tecpromotion - test_item - 17 Sep 2024 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 17 Sep 2024

I have tested this item ✅ successfully on 00ac35d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091.

avatar tecpromotion
tecpromotion - comment - 17 Sep 2024

RTC

avatar richard67 richard67 - change - 17 Sep 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Sep 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091.

avatar Quy Quy - change - 18 Sep 2024
Labels Added: RTC
avatar Hackwar
Hackwar - comment - 23 Sep 2024

Thank you for your contribution @obuisard!

avatar Hackwar Hackwar - change - 23 Sep 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-23 09:02:38
Closed_By Hackwar
avatar Hackwar Hackwar - close - 23 Sep 2024
avatar Hackwar Hackwar - merge - 23 Sep 2024

Add a Comment

Login with GitHub to post a comment