?

Success

User tests: Successful: Unsuccessful:

avatar nternetinspired
nternetinspired
30 Sep 2014

Link not unto thyself

When linked article titles are enabled titles are not only linked to from blog, featured and list pages, but also in the article view itself. This is clearly nonsensical, as the linked title of /my-awesome-post links only to /my-awesome-post.

This PR removes title linking in the article view.

Test

After applying this patch an article title will no longer pointlessly link to itself, saving link-juice, mobius-logic and link-colored pixels.

avatar nternetinspired nternetinspired - open - 30 Sep 2014
avatar jissues-bot jissues-bot - change - 30 Sep 2014
Labels Added: ?
avatar brianteeman
brianteeman - comment - 30 Sep 2014

Thanks for doing this one. Its been on my personal to do list but as I had
done my own override I keep forgetting
On 30 Sep 2014 15:35, "Seth Warburton" notifications@github.com wrote:

Link not unto thyself

When linked article titles are enabled titles are not only linked to from
blog, featured and list pages, but also in the article view itself. This is
clearly nonsensical, as the linked title of /my-awesome-post links only to
/my-awesome-post.

This PR removes title linking in the article view.
Test

After applying this patch an article title will no longer pointlessly link

to itself, saving link-juice, mobius-logic and link-colored pixels.

You can merge this Pull Request by running

git pull https://github.com/nternetinspired/joomla-cms check-yoself

Or view, comment on, or merge it at:

#4402
Commit Summary

  • Removes self-linking article title

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#4402.

avatar mbabker
mbabker - comment - 30 Sep 2014

Yay, one less thing I'd need to override :smile:

avatar nternetinspired
nternetinspired - comment - 30 Sep 2014

Same here. I've been overriding it for so long I forgot this could even still be a thing.

avatar brianteeman brianteeman - change - 30 Sep 2014
Category Components Templates (site) UI/UX
avatar Kubik-Rubik Kubik-Rubik - test_item - 1 Oct 2014 - Not tested
avatar Kubik-Rubik Kubik-Rubik - test_item - 1 Oct 2014 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 1 Oct 2014

Works as described, thank you!

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar infograf768 infograf768 - change - 1 Oct 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 1 Oct 2014

Makes sense. RTC

avatar roland-d roland-d - test_item - 1 Oct 2014 - Tested successfully
avatar phproberto phproberto - close - 2 Oct 2014
avatar zero-24 zero-24 - close - 2 Oct 2014
avatar phproberto phproberto - change - 2 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-02 00:33:23
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment