@tkempf please notice that travis is not happy with your code:

FILE: ...is/build/joomla/joomla-cms/components/com_finder/models/suggestions.php

--------------------------------------------------------------------------------

FOUND 19 ERROR(S) AND 4 WARNING(S) AFFECTING 18 LINE(S)

--------------------------------------------------------------------------------

  68 | ERROR   | Whitespace found at end of line

  77 | ERROR   | Whitespace found at end of line

  86 | ERROR   | Whitespace found at end of line

  87 | WARNING | Expected 1 space after "="; 0 found

  87 | ERROR   | Expected 1 space before "="; 0 found

  94 | WARNING | Expected 1 space after ".="; 0 found

  94 | ERROR   | Expected 1 space before ".="; 0 found

  95 | WARNING | Expected 1 space after "<"; 0 found

  95 | ERROR   | Expected 1 space before "<"; 0 found

  96 | WARNING | Expected 1 space after ".="; 0 found

  96 | ERROR   | Expected 1 space before ".="; 0 found

  98 | ERROR   | No space found after comma in function call

 101 | ERROR   | Whitespace found at end of line

 105 | ERROR   | Whitespace found at end of line

 109 | ERROR   | Functions and classes must not contain multiple empty lines in

     |         | a row; found 2 empty lines

 113 | ERROR   | No space found after comma in function call

 114 | ERROR   | No space found after comma in function call

 115 | ERROR   | No space found after comma in function call

 115 | ERROR   | No space found after comma in function call

 116 | ERROR   | Whitespace found at end of line

 118 | ERROR   | Whitespace found at end of line

 120 | ERROR   | Whitespace found at end of line

 161 | ERROR   | Whitespace found at end of line

--------------------------------------------------------------------------------


FILE: ...home/travis/build/joomla/joomla-cms/modules/mod_finder/tmpl/default.php

--------------------------------------------------------------------------------

FOUND 2 ERROR(S) AFFECTING 1 LINE(S)

--------------------------------------------------------------------------------

 130 | ERROR | Concat operator must be followed by one space

 130 | ERROR | Concat operator must be preceeded by one space

--------------------------------------------------------------------------------

see: https://travis-ci.org/joomla/joomla-cms/jobs/36741145

I'm testing this in J3.4.1 and it is working okay.
Thanks, tkempf.

I tested with version: Joomla 3.4.4-dev development

1) Enable the Smart Search Plugin
2) Go to the Smart Search Component and click "Index" to get some results
3) Have a look at the Frontend and the Smart Search module and test the autosuggestion there
4) Search for an article that is unpublished - with the patch this one should not be suggested anymore
5) Search for an article that will be published in future - with the patch this one should not be suggested anymore
6) Search for an article that is only for Super Users and you are not logged in at the Frontend - with the patch this one should not be suggested anymore
7) Create a Search Filter and use the Smart Search of the Frontend to find it

Result: After I applied the patch, the whole suggestions in the Smart Search didn't work anymore. As an example I searched for "similar" because there is an article called "Similar Tags" and this one should be suggested.
I attached a screenshot of the suggestion before the patch was applied, and after it was applied.

Before the Patch was applied:

After the Patch was applied:

Using Joomla Version : 3.4.4-dev.
Enable Smart Search Plugin. Tested a while. After I applied the Plugin and go to my smartsearch in the Frontend, I get a blank Page...

@tkempf can you try to get the code working on the current staging? Based on the last tests it don't work. Please add a comment if you have find the issue. Thanks.

code is now working again on current staging. There was an issue when no filter was selected. Can you pls. reopen.
While testing i found that the content - finder plugin does not reflect state changes in the search index items. IMO disabling an article should disable the corresponding search index item. Pls. correct me if i am wrong...

I confirm patch this one should not be suggested anymore.

Thank you for creating this but it would appear that this has been resolved elsewhere in the code base. If this is not correct then this can be re-opened

I just tested on J3.5.1 and autosuggester does not respect for example access level: as a guest I get a suggestion for a Administrator level article, so it is not resolved in codebase?

@brianteeman Should this be closed too as unfixable per #16011?