[#43977] - [6.1] [CLI] enable or disable extension command
- Ready to Commit
- Medium
- Build: 5.2-dev
- # 43977
- Diff
- alikon:cli-publish-extid
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43949 .
Summary of Changes
new command to enable or disable an extension
Testing Instructions
run php cli\joomla.php extension:enable 226
run php cli\joomla.php extension:disable 226 to disable
Actual result BEFORE applying this Pull Request
N/A
Expected result AFTER applying this Pull Request
enable or disable an extension from cli
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.2-dev
|
||
| Title |
|
||||||
I think it would be better to have two separate commands for enabling and disabling extensions: extension:enable and extension:disable. In my opinion, it is a bit confusing that the command "publish" also disables extensions.
Joomla has separate commands for installing and uninstalling extensions, as well as for getting and setting configuration values an so on. There is no commands such:
php cli/joomla extension:install --uninstall 123
php cli/joomla user:add --delete bob
php cli/joomla site:up --down
php cli/joomla database:export --import| Labels |
Added:
Feature
PR-5.3-dev
Removed: PR-5.2-dev |
||
2 separate command now
Shouldnt all usage of publish/unpublish (including the file names) be changed to enable/disable?
I think we should use enable/disable instead of publish/unpublish. Even a field in database has name enabled:
$table->enabled = 1;
I have tested this item ✅ successfully on 43ef558
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43977.
This pull request has been automatically rebased to 6.0-dev.
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-24 21:45:55 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
PR-6.0-dev
Removed: PR-5.3-dev |
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2025-03-24 21:45:55 | ⇒ | |
| Closed_By | alikon | ⇒ |
| Status | New | ⇒ | Pending |
| Category | Libraries | ⇒ | Libraries JavaScript Unit Tests |
| Labels |
Added:
Unit/System Tests
|
||
I have tested this item ✅ successfully on caf8574
I have tested this very successfully and satisfyingly ;) Thanks @alikon!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43977.
I have not tested this item.
tested that you can not disable a protected extension
tested that you can disable a non-protected extension
tested that you can not enable an already enabled extension
tested that you can not disable an already disabled extension
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43977.
I have not tested this item.
@brianteeman Really not tested? Or just not selected the test result in the issue tracker before submitting?
Looks like github did not record the changed test
@brianteeman GitHub recorded it in the counter, so it shows all checks have passed. But the alter test result does not trigger an extra comment in the thread like a test result submission does, that's what confused me.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43977.
This pull request has been automatically rebased to 6.1-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.3-dev.