bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
5 Sep 2024

Summary of Changes

Schemaorg system plugin onContentAfterDelete event tries do delete the schema even if context is not supported, and we have a warning if an item doesn't have id attribute.

Testing Instructions

Delete any item of custom component which doesn't implement SchemaorgServiceInterface or doesn't have id attribute.

Actual result BEFORE applying this Pull Request

See a similar warning in error log:

PHP Warning:  Undefined property: Xxx\\Component\\Xxx\\Administrator\\Table\\Xxx::$id in /var/www/public_html/plugins/system/schemaorg/src/Extension/Schemaorg.php on line 545

Expected result AFTER applying this Pull Request

No warning, only items which support schemaorg and with ID column are deleted.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Denitz Denitz - open - 5 Sep 2024
avatar Denitz Denitz - change - 5 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2024
Category Front End Plugins
avatar Denitz Denitz - change - 5 Sep 2024
Labels Added: PR-5.1-dev
avatar richard67 richard67 - change - 22 Sep 2024
Labels Added: bug PR-5.2-dev
Removed: PR-5.1-dev
avatar richard67 richard67 - change - 22 Sep 2024
Build 5.1-dev 5.2-dev
avatar HLeithner HLeithner - change - 15 Nov 2024
Title
Schemaorg system plugin onContentAfterDelete issue
[5.2] Schemaorg system plugin onContentAfterDelete issue
avatar HLeithner HLeithner - edited - 15 Nov 2024

Add a Comment

Login with GitHub to post a comment