[#43968] - [cypress] Add db_port in Installation.cy.js
- Fixed in Code Base
- 23 Oct 2024
- Medium
- Build: 4.4-dev
- # 43968
- Diff
- muhme:patch-1
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request as a puzzle piece of Issue #43902
Summary of Changes
In the installation step of the system tests, support for the configuration of the database port is added.
Testing Instructions
The only isolated test that can be carried out for this change is that it does no harm.
You could see this PR is already used as hack in Joomla Branches Tester. There you can see it working in scripts/cypress.sh 44 local and running the Installation.cy.js step. Without the change (you have to comment-out the change in tests/System/integration/install/Installation.cy.js the Joomla Web Installer fails with:
Could not connect to the database. Connector returned error message: No such file or directory
Actual result BEFORE applying this Pull Request
The System Tests installation step cannot set the database port.
Expected result AFTER applying this Pull Request
The System Tests installation step can set the database port.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
See also my PR for the database framework: joomla-framework/database#310 . Would be good to know if the PR here still works with the changes from my framework PR.
from my testing result with joomla-framework/database#310
just set db_host: 'localhost:5433', proprerly in cypress.config.js
| Labels |
Added:
Unit/System Tests
PR-4.4-dev
|
||
I have tested this item ✅ successfully on 9c2a993
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43968.
Can you rebase this one to 5.2?
| Category | JavaScript Unit Tests | ⇒ | Unit Tests Repository Administration com_admin SQL |
Rebased on 5.2-dev and checked System Tests on macOS with MariaDB passed
| Labels |
Added:
PR-5.2-dev
Removed: PR-4.4-dev |
||
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ | JavaScript Unit Tests |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-23 03:50:48 |
| Closed_By | ⇒ | laoneo |
Thanks!
Looks good to me.