[#43967] - [4.4] Pagination fixes part 2
- Fixed in Code Base
- 23 Aug 2024
- Medium
- Build: 4.4-dev
- # 43967
- Diff
- SniperSister:fix/pagination-fixes-v2
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
The 4.4.7 and 5.1.3 security release broke the pagination in com_finder and the com_content archive view. Furthermore, parameters were read from $_REQUEST and not from $_GET.
Testing Instructions
Enable the "Show Sort Fields" setting in the Smart Search menu item (under Advanced).
Then use the ordering fields to change the order, in a result set that has several pages and try to change page.
Actual result BEFORE applying this Pull Request
- The ordering field and direction are vanished.
Expected result AFTER applying this Pull Request
- The ordering field and direction are kept.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content com_finder Libraries |
| Labels |
Added:
PR-4.4-dev
|
||
| Category | Front End com_content com_finder Libraries | ⇒ | Front End com_content com_finder |
I have tested this item ✅ successfully on 6d4b67a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43967.
I have tested this item ✅ successfully on 6d4b67a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43967.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43967.
MacJoom
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-23 17:17:49 |
| Closed_By | ⇒ | MacJoom | |
| Labels |
Added:
RTC
|
||
@sakiss PR is ready. Could you test? And if successful, go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43967 and mark your test result by using the blue "Test this" button at the top left corner? Thanks in advance.