[#43906] - [4.4] Correct file size validation for Media component
- Fixed in Code Base
- 12 Sep 2024
- Medium
- Build: 4.4-dev
- # 43906
- Diff
- Fedik:fix-media-file-size-check
User tests: Successful: Unsuccessful:
Pull Request for Issue #43387 .
Alternative to #43904
Summary of Changes
Fix media manager ApiController to check actual file size, instead of POST size.
Testing Instructions
Please follow #43387
Actual result BEFORE applying this Pull Request
False error
Expected result AFTER applying this Pull Request
No false error
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
| Status | New | ⇒ | Pending |
| Labels |
Added:
bug
PR-4.4-dev
|
||
Followed the instructions - and got the expected error message.
After applying the Patch, I got:
The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_media/src/Controller/ApiController.php
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43906.
Followed the instructions - and got the expected error message.
After applying the Patch, I got:
The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_media/src/Controller/ApiController.php
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43906.
Please make sure you don't have other patches applied.
tks @Quy. If I had applied other patches, I wouldn't have been able to "fetch". Because then a different message would appear after fetch data. I'll check again.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43906.
As a test I also tried a different pr (patch). This one was displayed. I tried again, unfortunately I now have error 500 (backend) Frontend OK. So I have to pass now .....
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43906.
So, I was able to clear the 500 error. It was a MySQL issue.
After "fetch data" I got the above message again.
So I clicked "Reset" and everything was fine again.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43906.
I have tested this item ✅ successfully on 883539f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43906.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43906.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-12 09:30:10 |
| Closed_By | ⇒ | MacJoom |
Thank you!
I have tested this item ✅ successfully on 883539f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43906.