Feeling Lucky
bug
PR-4.4-dev
[#43904] - [4.4] Incorrect file size validation in media manager
- Closed
- 11 Aug 2024
- Medium
- Build: 4.4-dev
- # 43904
- Diff
- brianteeman:base64
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
PR for #43387
the Base64 version of a string or file is typically roughly a third larger than its source so this adds a 1.33 factor to the size calculation
See #43387 and https://developer.mozilla.org/en-US/docs/Glossary/Base64#encoded_size_increase for more information
Test instructions
- media manager set to 4mb
Try to upload a file just below 4mb in size
Before
Image is rejected as too large
After
Image is accepted
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.4-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-11 11:33:36 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
bug
|
||
Thanks for your effort and for the hint.
However I just checked the ApiController code, and whole
checkContent()is strange piece of code.We actualy already have the file content in bytes at
joomla-cms/administrator/components/com_media/src/Controller/ApiController.php
Line 198 in f8003bc
that where the Controller should validate this size, instead of checking POST size as it done in
checkContent().