User tests: Successful: 1 exlemor Unsuccessful: 0
Pull Request for Issue # .
This Pull request rewrites the #35228 as meanwhile many changes were made.
The purpose of theis PR is to merge the "featured" articles into the articles classes and remove duplicate code from com_content
This PR changes only the backend, nothing in frontend.
See PR #35228
Additionally the quickicon "featured".
as described in #35228, plus a view on quickicons
If you test on an existing site, please do this as first step:
UPDATE #__menu
SET link
= 'index.php?option=com_content&view=articles&featured=1'
WHERE link
= 'index.php?option=com_content&view=featured'
AND client_id
= 1;
See PR #35228
Please select:
Documentation link for docs.joomla.org: help doc and tbd
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql com_content com_menus Modules |
Labels |
Added:
PR-6.0-dev
|
I thought the policy was deprecated in x and removed in x+2 ?
The PR has the support of the Enhancement Development team. This is still something the team wants to talk to the maintenance team and the release managers for 6.0 about: we do think it would make future changes to the core simpler if this PR was merged early on and tested throughout the 6.0 pre-release cycle.
Adding the following code in the DisplayController will prevent old URLs to fail with 500 error but be redirected to the 'articles' view instead.
if ($view == 'featured') {
$this->setRedirect(Route::_('index.php?option=com_content&view=articles&featured=1', false));
return false;
}
Just started a new Installation. I think that the first select "All" is not self-explaining.
Would "featured / unfeatured " be better? The text is rather long especially in other languages. or " - select featured - " ?
In my opinion, " - select featured - ", "featured", "unfeatured" sounds better.
The filter needs to be changed. It cannot be featured / unfeatured but also needs a value "all".
-- select featured --
all
featured
unfeatured
Labels |
Added:
Feature
|
Title |
|
Created a new site and added sample data.
Unfeatured articles leaving only 1 of the 11 articles featured
Content > Featured Articles displayed the 1 article that was featured. The item count showed 1-11/11 items, should this be 1-1/1 items since only 1 article is featured?
Content > Articles displayed only the featured article with the selector set at Featured Articles. Should the selector be Select Featured?
With sample data, do you mean testing sample data (the old plugin for developers) or blog sample data? When I install blog sample data, every count is correct for me.
Hi @chmst,
Other than the double highlighting bug mentioned in #35228, I was able to test successfully...
( noticed after the fact that it couldn't be tested on 5.2.3 and the update 5.2.3 ---> 6.0.0 alpha 1 created a *@%#! so then I wiped everything and installed Joomla_6.0.0-alpha1-dev+pr.43907-Development-Full_Package.zip. ).
I have tested this item ✅ successfully on fab5f02
Aside from my comment on the PR, I was able to test it successfully.
Thank you for the hard work.
@chmst There are still code style issues, e.g. unused imports (
use
statements) to be removed. Unfortunately many of them are outside of what can be done with a code change suggestion on GitHub, so I can't help with suggestions here. See the log here: https://ci.joomla.org/joomla/joomla-cms/78000/1/7 . If necessary I can help tomorrow after work. Would be good to get the phpcs fixed so the system tests will be started in Drone.