[#43907] - [6.0] [WIP] Gsoc2021 35228 merge featured
- Pending
- Medium
- Build: 6.0-dev
- # 43907
- Diff
- chmst:gsoc2021-35228-merge-featured
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This Pull request rewrites the #35228 as meanwhile many changes were made.
The purpose of theis PR is to merge the "featured" articles into the articles classes and remove duplicate code from com_content
This PR changes only the backend, nothing in frontend.
Summary of Changes
See PR #35228
Additionally the quickicon "featured".
Testing Instructions
as described in #35228, plus a view on quickicons
If you test on an existing site, please do this as first step:
UPDATE #__menu
SET link = 'index.php?option=com_content&view=articles&featured=1'
WHERE link = 'index.php?option=com_content&view=featured'
AND client_id = 1;
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
See PR #35228
Link to documentations
Please select:
-
Documentation link for docs.joomla.org: help doc and tbd
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql com_content com_menus Modules |
| Labels |
Added:
PR-6.0-dev
|
||
- @deprecated 6.0 will be removed in 7.0
I thought the policy was deprecated in x and removed in x+2 ?
- Full prebuilt package installation.
- Blog sample data installation failed (red
There is an error in a sample data plugin. Response is invalid.) - Saving new Article:
Article not saved.
The PR has the support of the Enhancement Development team. This is still something the team wants to talk to the maintenance team and the release managers for 6.0 about: we do think it would make future changes to the core simpler if this PR was merged early on and tested throughout the 6.0 pre-release cycle.
Adding the following code in the DisplayController will prevent old URLs to fail with 500 error but be redirected to the 'articles' view instead.
if ($view == 'featured') {
$this->setRedirect(Route::_('index.php?option=com_content&view=articles&featured=1', false));
return false;
}
Just started a new Installation. I think that the first select "All" is not self-explaining.
Would "featured / unfeatured " be better? The text is rather long especially in other languages.
or " - select featured - " ?
Just started a new Installation. I think that the first select "All" is not self-explaining.
Would "featured / unfeatured " be better? The text is rather long especially in other languages. or " - select featured - " ?
In my opinion, " - select featured - ", "featured", "unfeatured" sounds better.
@chmst There are still code style issues, e.g. unused imports (
usestatements) to be removed. Unfortunately many of them are outside of what can be done with a code change suggestion on GitHub, so I can't help with suggestions here. See the log here: https://ci.joomla.org/joomla/joomla-cms/78000/1/7 . If necessary I can help tomorrow after work. Would be good to get the phpcs fixed so the system tests will be started in Drone.