Feature PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
11 Aug 2024

Pull Request for Issue # .
This Pull request rewrites the #35228 as meanwhile many changes were made.

The purpose of theis PR is to merge the "featured" articles into the articles classes and remove duplicate code from com_content
This PR changes only the backend, nothing in frontend.

Summary of Changes

See PR #35228
Additionally the quickicon "featured".

Testing Instructions

as described in #35228, plus a view on quickicons

If you test on an existing site, please do this as first step:

UPDATE #__menu
SET link = 'index.php?option=com_content&view=articles&filter[featured]=1'
WHERE link = 'index.php?option=com_content&view=featured'
AND client_id = 1;

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

See PR #35228

Link to documentations

Please select:

  • Documentation link for docs.joomla.org: help doc and tbd

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: tbd

  • No documentation changes for manual.joomla.org needed

avatar chmst chmst - open - 11 Aug 2024
avatar chmst chmst - change - 11 Aug 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2024
Category SQL Administration com_admin Postgresql com_content com_menus Modules
avatar chmst chmst - change - 11 Aug 2024
The description was changed
avatar chmst chmst - edited - 11 Aug 2024
avatar chmst chmst - change - 11 Aug 2024
The description was changed
avatar chmst chmst - edited - 11 Aug 2024
avatar chmst chmst - change - 11 Aug 2024
The description was changed
avatar chmst chmst - edited - 11 Aug 2024
e97f37c 11 Aug 2024 avatar chmst cs
avatar chmst chmst - change - 11 Aug 2024
Labels Added: PR-6.0-dev
avatar richard67
richard67 - comment - 11 Aug 2024

@chmst There are still code style issues, e.g. unused imports (use statements) to be removed. Unfortunately many of them are outside of what can be done with a code change suggestion on GitHub, so I can't help with suggestions here. See the log here: https://ci.joomla.org/joomla/joomla-cms/78000/1/7 . If necessary I can help tomorrow after work. Would be good to get the phpcs fixed so the system tests will be started in Drone.

avatar brianteeman
brianteeman - comment - 11 Aug 2024

I thought the policy was deprecated in x and removed in x+2 ?

10532bc 12 Aug 2024 avatar chmst cs
10ff935 12 Aug 2024 avatar chmst cs
796a00d 12 Aug 2024 avatar chmst cs
de442db 13 Aug 2024 avatar chmst cs
2a3a615 14 Aug 2024 avatar chmst cs
avatar richard67
richard67 - comment - 20 Aug 2024

@chmst Does this PR replace PR #35228 ? If yes, shall we close the latter?

And could you check the conflicting files? I think the conflicts come from PRs #43323 and #43512 , but I don't have the time now to check in detail.

avatar richard67
richard67 - comment - 20 Aug 2024

@chmst I've allowed myself to fix the conflicts. Please check the result.

avatar fgsw
fgsw - comment - 21 Aug 2024
  1. Full prebuilt package installation.
  2. Blog sample data installation failed (red There is an error in a sample data plugin. Response is invalid.)
  3. Saving new Article:
    UntitledArticle not saved.
avatar obuisard
obuisard - comment - 27 Aug 2024

The PR has the support of the Enhancement Development team. This is still something the team wants to talk to the maintenance team and the release managers for 6.0 about: we do think it would make future changes to the core simpler if this PR was merged early on and tested throughout the 6.0 pre-release cycle.

avatar brianteeman
brianteeman - comment - 27 Aug 2024

@obuisard thats what is always said and the fixes never happen. Once it is merged then the people behind it move on to other things.

avatar obuisard
obuisard - comment - 24 Sep 2024

Adding the following code in the DisplayController will prevent old URLs to fail with 500 error but be redirected to the 'articles' view instead.

if ($view == 'featured') {
    $this->setRedirect(Route::_('index.php?option=com_content&view=articles&featured=1', false));
    return false;
}
avatar chmst
chmst - comment - 24 Sep 2024

Just started a new Installation. I think that the first select "All" is not self-explaining.
grafik

Would "featured / unfeatured " be better? The text is rather long especially in other languages.
or " - select featured - " ?

avatar richard67
richard67 - comment - 24 Sep 2024

@chmst Could you check the conflict in file „administrator/components/com_content/tmpl/featured/default.php“? I think it comes from #44053 .

avatar obuisard
obuisard - comment - 24 Sep 2024

Just started a new Installation. I think that the first select "All" is not self-explaining.
Would "featured / unfeatured " be better? The text is rather long especially in other languages. or " - select featured - " ?

In my opinion, " - select featured - ", "featured", "unfeatured" sounds better.

avatar chmst
chmst - comment - 14 Dec 2024

The filter needs to be changed. It cannot be featured / unfeatured but also needs a value "all".

-- select featured --
all
featured
unfeatured

avatar chmst chmst - change - 15 Dec 2024
Labels Added: Feature
avatar chmst chmst - change - 16 Dec 2024
Title
[6.0] [WIP] Gsoc2021 35228 merge featured
[6.0] Gsoc2021 35228 merge featured
avatar chmst chmst - edited - 16 Dec 2024
dd99cd8 16 Dec 2024 avatar chmst cs
avatar sdwjoomla
sdwjoomla - comment - 14 Jan 2025

Created a new site and added sample data.
Unfeatured articles leaving only 1 of the 11 articles featured

Content > Featured Articles displayed the 1 article that was featured. The item count showed 1-11/11 items, should this be 1-1/1 items since only 1 article is featured?

Content > Articles displayed only the featured article with the selector set at Featured Articles. Should the selector be Select Featured?

avatar chmst
chmst - comment - 14 Jan 2025

With sample data, do you mean testing sample data (the old plugin for developers) or blog sample data? When I install blog sample data, every count is correct for me.

avatar exlemor
exlemor - comment - 28 Jan 2025

Hi @chmst,

Other than the double highlighting bug mentioned in #35228, I was able to test successfully...

( noticed after the fact that it couldn't be tested on 5.2.3 and the update 5.2.3 ---> 6.0.0 alpha 1 created a *@%#! so then I wiped everything and installed Joomla_6.0.0-alpha1-dev+pr.43907-Development-Full_Package.zip. ).

avatar exlemor exlemor - test_item - 28 Jan 2025 - Tested successfully
avatar exlemor
exlemor - comment - 28 Jan 2025

I have tested this item ✅ successfully on fab5f02

Aside from my comment on the PR, I was able to test it successfully.

Thank you for the hard work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43907.

avatar obuisard
obuisard - comment - 2 Feb 2025

Hello @SharkyKZ, any reason for the thumb down?

avatar chmst chmst - change - 22 Feb 2025
The description was changed
avatar chmst chmst - edited - 22 Feb 2025
avatar chmst
chmst - comment - 22 Feb 2025

With new changes, the filter goes back into the normal filter toolbar, so that user do not see a differnce against J5, we do not need make changes in user documentation.

At the moment we have one flaw - the featured link in the admin module ist not marked as active.

avatar obuisard
obuisard - comment - 22 Feb 2025

Everything works flawlessly and I like this change. Great thanks Christiane @chmst.

I do have one comment, which is a behavior I have noticed:

  • when you filter articles by a category, for instance 'blog', then go somewhere else, for instance in the 'fields' page and then you go back to the articles view, the filter 'blog' is still selected (and everything works that way for categories...).
  • when you filter articles by category 'blog', then go to 'featured articles' view, the category 'blog' is no longer selected.

This is reproducing the behavior we had before this PR: when going to the 'featured articles' view, we had a featured articles view you could filter independently from the articles view. But now that the views are merged, we cannot have distinct filtering any longer.

I do think that for consistency with the other pages, we should retain filters while switching between 'articles' and 'featured articles' views.

avatar exlemor
exlemor - comment - 22 Feb 2025

I have tested this again thoroughly and agree with Olivier, aside from the oddity he describes, it works but it would b great if that oddity was solved.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43907.

avatar obuisard obuisard - test_item - 24 Feb 2025 - Tested successfully
avatar obuisard
obuisard - comment - 24 Feb 2025

I have tested this item ✅ successfully on fab5f02


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43907.

avatar softforge softforge - change - 24 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-24 15:29:33
Closed_By softforge
avatar softforge softforge - close - 24 Feb 2025
avatar softforge softforge - merge - 24 Feb 2025
avatar laoneo
laoneo - comment - 25 Feb 2025

Is this documented?

avatar softforge
softforge - comment - 25 Feb 2025

Hi, @chmst, Thank you for persisting and getting to this point.
Would you mind providing some documentation for the manual.joomla.org? I am sure Anja will be wanting to get an article about it for the magazine as well

avatar chmst
chmst - comment - 25 Feb 2025

I am happy that it is merged - thanks to all who helped with that. I am pretty sure that there will come some more issues.

@laoneo will do documentation in the manual for deprecations. There is no change in the views and users should not see any difference.

@softforge - will see what I can do

Add a Comment

Login with GitHub to post a comment