[#43891] - [4.0] close collapse when opening a dropdown
- Fixed in Code Base
- 9 Aug 2024
- Medium
- Build: 4.4-dev
- # 43891
- Diff
- hans2103:feature/close-collapse-when-opening-dropdown
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28952 .
Summary of Changes
This PR will add some javascript.
When you click on a dropdown element (data-bs-toggle="dropdown") , all open collapse elements (data-bs-toggle="collapse") will close
Testing Instructions
- Joomla 4.4-dev with demo data
- resize viewport to mobile
- toggle any of the three buttons in the footer to open / close the element
- see the issue as shown in the first screencapture movie
- run
npm cito compile both css and js - toggle any of the three buttons in the footer to open / close the element
- see the issue as shown in the second screencapture movie
Actual result BEFORE applying this Pull Request
Screen.Recording.2024-08-07.at.11.10.00.mov
Expected result AFTER applying this Pull Request
Screen.Recording.2024-08-07.at.11.44.36.mov
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
@hans2103 Please fix the javascript cs issues reported here https://ci.joomla.org/joomla/joomla-cms/77860/1/33 :
/drone/src/build/media_source/templates/administrator/atum/js/template.es6.js
251:25 error Expected parentheses around arrow function argument arrow-parens
252:36 error Unexpected unnamed function func-names
252:36 error Unexpected function expression prefer-arrow-callback
253:29 error Expected parentheses around arrow function argument arrow-parens
256:22 error Missing trailing comma comma-dangle
| Labels |
Added:
NPM Resource Changed
PR-4.4-dev
|
||
@richard67 lint:js issue have been fixed
@brianteeman please feel free to test again. (same goes for the rest of the world, but you are faster)
I have tested this item ✅ successfully on c3a925f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891.
I have tested this item ✅ successfully on c3a925f
I have tested this successfully... :)
( Thanks for this fix, I sometimes have to use my mobile phone and this will help! )
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-09 06:31:46 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
|
||
Thanks!
Given that accordions are also using data-bs-toggle="collapse" it also causes all accordions tabs to close.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891.
I have tested this item ✅ successfully on 3d7b7df
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891.