Unit/System Tests NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar muhme
muhme
7 Aug 2024

Summary of Changes

The goal is to use the NPM joomla-cypress version 1.1.1 for all four active joomla-cms branches. Actual 4.4-dev uses 0.0.16 and 5.1-dev, 5.2-dev and 6.0-dev are using 1.0.3.

For 4.4-dev there is already PR #43722

This PR is for branches 5.1-dev and 5.2-dev (see at the end).

Change:

  • The joomla-cypress version is set to ^1.1.1, so - among other things - PHP warnings are speaking (tell you what was going wrong) and ready for 5.2 guided tours new 'Skip Tour'
  • The note about overwritten commands in tests/System/README.md is deleted, it was only valid for 4.4-dev

Successfully pretested with all System Tests passed:

  • on Intel macOS 14.5 Sonoma with PHP 8.3.9

⚠️ Only NPM package joomla-cypress was updated, BUT there are more changes in package-lock.json. ⚠️

  • Reason is dependend packages like cypress and cypress-file-upload

Testing Instructions

  • Install (in using npm ci) and run System Tests w/o errors
  • Check version is 1.1.1 in node_modules/joomla-cypress/package.json
  • Check that the additional updates in the package-lock.json file had no effect.

Actual result BEFORE applying this Pull Request

  • System Tests is using joomla-cypress version 1.0.3
  • System Tests suite is running without errors

Expected result AFTER applying this Pull Request

  • System Tests is using joomla-cypress version 1.1.1
  • System Tests suite is running without errors

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Up-Merging 5.2-dev

For [5.2] Guided Tours #43814 joomla-cypress 1.1.1 is required to handle new 'Skip Tour' with Cypress custom command cancelTour.

@laoneo This PR was successfully pretested on 5.2-dev branch with all System Tests passed:

  • on Intel macOS 14.5 Sonoma with PHP 8.3.9

⚠️ Only NPM package joomla-cypress was updated, BUT there are more changes in package-lock.json. ⚠️

  • Reasons are
    • Dependend packages like cypress and cypress-file-upload
    • package.json and package-lock.json were not in-sync. For example in package.json the version is stated as '5.2.0' and in package-lock.json as '5.1.2'.

Up-Merging 6.0-dev

Was not tested and needs first #43642 to be merged.

avatar muhme muhme - open - 7 Aug 2024
avatar muhme muhme - change - 7 Aug 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2024
Category NPM Change Unit Tests Repository
avatar laoneo
laoneo - comment - 7 Aug 2024

Closing this one as it was only to test if it works on 5 as well, coordinated with @muhme already. Changes will come through the upmerge then into 5.

avatar laoneo laoneo - close - 7 Aug 2024
avatar laoneo laoneo - change - 7 Aug 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-08-07 16:42:56
Closed_By laoneo
Labels Added: Unit/System Tests NPM Resource Changed PR-5.1-dev

Add a Comment

Login with GitHub to post a comment