[#43842] - [5.2] Feat: Showon for Use Global Option in ListField
- Fixed in Code Base
- 26 Jul 2024
- Medium
- Build: 5.2-dev
- # 43842
- Diff
- LadySolveig:5.2/feat/useglobal-showon
User tests: Successful: Unsuccessful:
Pull Request for Issue #42381.
Summary of Changes
At the moment showon fields doesn't work in combination with global options.
The changes introduce a new data-attribute 'data-global' in select option if useglobal in ListField is set to true and adds support in showon script.
Testing Instructions
Run npm install
Set Global Configuration -> Contacts: Options -> Tab: Contact Information --> Show
Open a contact in edit mode or add a new contact.
Set Contacts: Edit -> Tab: Display -> Contact Information --> Use Global (Show)
Actual result BEFORE applying this Pull Request
Showon will be ignored and the additional fields are not visible.
Additional fields are only available after explicitly setting the option to show
Expected result AFTER applying this Pull Request
Works as expected and the fields are shown also with Use Global (Show)
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Libraries |
LGTM
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
In general I am not a big fan of this "global hack" that we have, because it is a hack on the hack.
But the PR looks good, if it works ?
I have tested this item ✅ successfully on df7232c
I was able to test this successfully with the help of Martina. (thanks Martina).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43842.
richard67
- 
I have tested this item ✅ successfully on 005d060
From usability point of view the whole concept of "use global" should be improved, but this is not in scope.
And the PR resolves the issue - thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43842.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43842.
| Labels |
Added:
Feature
RTC
|
||
Thank you for this contribution @LadySolveig!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-26 18:47:14 |
| Closed_By | ⇒ | Hackwar |
Would be nice if you could have a look at this fix @Fedik @dgrammatiko ?