[#43841] - Add Language string DELETE_FROM_TRASH and replace alle occurences of …
- Fixed in Code Base
- 31 Jul 2024
- Medium
- Build: 5.2-dev
- # 43841
- Diff
- chmst:replace-empt-trash-in-listviews
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #41106 .
Replacement for PR #41119.
Summary of Changes
The String "Empty Trash"in list views is replaced by "Delete". To avoid a b/c break by modifying the Language String a new Languages string has been added.
Testing Instructions
Code review, have a look on list views when the state filter is set to "trashed"
Actual result BEFORE applying this Pull Request
The Button says "Empty Trash"
Expected result AFTER applying this Pull Request
The Button says "Delete"
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_messages com_modules com_newsfeeds com_redirect com_tags com_users com_workflow Language & Strings Libraries |
I have tested this item ✅ successfully on e66327e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43841.
Why add another string? Use JTOOLBAR_DELETE.
Why add another string? Use
JTOOLBAR_DELETE.
because it is a b/c break as it is more than a grammar or typo correction. See original PR for more
@HLeithner suggested the same thing. #41119 (comment)
Hackwar
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
RTC
Language Change
PR-5.2-dev
|
||
@HLeithner suggested the same thing. #41119 (comment)
was a bad idea
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-31 17:53:28 |
| Closed_By | ⇒ | rdeutz |
Please describe millestone 5.2, this PR is not visible to translators. I only discovered it when comparing versions.
As I wrote on the original PR
Technically this PR is correct however