RTC Language Change PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Jul 2024

Summary of Changes

This PR adds two new menu items to the save dropdown menu on the toollbar allowing you to save a categorey directly to a menu item - either as a blog or a list just as you can directly save an article to a menu item.

This is currently restricted to categories in the com_content component. It could be expanded to other components but I didn't see the use case

Testing Instructions

Check that there are two new items in the save group as shown only for categories in com_content and not other places that categories are used such as banners and contacts

image

Check that both new items work as expected and create blog or list menu items as shown for both new and existing categories

Save to Menu as List

image

Save to Menu as Blog

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 24 Jul 2024
avatar brianteeman brianteeman - change - 24 Jul 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2024
Category Administration com_categories Language & Strings
avatar brianteeman brianteeman - change - 24 Jul 2024
Labels Added: Language Change PR-5.2-dev
avatar LadySolveig LadySolveig - test_item - 24 Jul 2024 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 24 Jul 2024

I have tested this item ✅ successfully on b38b05d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840.

avatar tecpromotion tecpromotion - test_item - 25 Jul 2024 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 25 Jul 2024

I have tested this item ✅ successfully on 224214d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840.

avatar rdeutz
rdeutz - comment - 25 Jul 2024

Is the menu text not a bit imprecise. We have "Save & Close" what does what it says, but the "Save to Menu as List" is more Save & Close & Add List Menu Item. I know it is a bit long but maybe someoen else has a better idea. And yes I know it is the same for article.

avatar brianteeman
brianteeman - comment - 25 Jul 2024

@rdeutz Beyond the scope of this pr for the reasons you stated. If German needs to be - more explicit then it can be done in the translation.

avatar PhocaCz
PhocaCz - comment - 25 Jul 2024

I think @rdeutz point of view is important. It is not so much about the language as about the logic of expression. Moreover, we must realize that English is not only English, but also the base language from which other languages ​​are based.

if I am to understand this feature, then I understand it in the case of:

Save & Close & Add List Menu Item

but I have no idea what it is about in the case of:

Save to Menu as List

And please take this as my personal opinion, I understand it as some kind of moving the article to some other group.

avatar LadySolveig
LadySolveig - comment - 25 Jul 2024

@rdeutz A completely different idea might even be to open it in a dialog. I find this sudden context switch somehow confusing. But maybe it's just me. But this is really out of scope of this PR. ?

avatar rdeutz
rdeutz - comment - 25 Jul 2024

@LadySolveig I was confused too, so we are two :-)

avatar brianteeman
brianteeman - comment - 25 Jul 2024

It is still out of scope of this PR as it is NOT a new behaviour. In fact Save to menu was added 5 years ago as a result of a survey in the german community to replace an existing toolbar button called new menu item

avatar PhocaCz
PhocaCz - comment - 25 Jul 2024

It is still out of scope of this PR as it is NOT a new behaviour. In fact Save to menu was added 5 years ago as a result of a survey in the german community to replace an existing toolbar button called new menu item

Thanks for the explanation, I understand now, sorry, my ignorance of this feature.

avatar exlemor exlemor - test_item - 25 Jul 2024 - Tested successfully
avatar exlemor
exlemor - comment - 25 Jul 2024

I have tested this item ✅ successfully on 224214d

I have tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840.
avatar brianteeman
brianteeman - comment - 26 Jul 2024

This has three successful tests - what do I need to do to get the status changed to RTC?

avatar Quy Quy - change - 26 Jul 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Jul 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840.

avatar Hackwar
Hackwar - comment - 26 Jul 2024

You might just want to give us some time. I do have an eye on this PR. But please also keep in mind that right now if we follow our own rules, we can basically only merge about one PR per hour and I'm not working on Joomla 24/7, so it might take a day or two to process this.

avatar brianteeman
brianteeman - comment - 26 Jul 2024

i was not chasing a merge just RTC so that others didnt waste their time on this one and tested something else

avatar Quy Quy - change - 27 Jul 2024
Labels Added: RTC
avatar Hackwar
Hackwar - comment - 29 Jul 2024

Thank you for your contribution @brianteeman! For now this is okay like this, in a future PR I would like to see this not restricted to just com_content, but to extend this to other components as well and make it a bit more flexible.

avatar brianteeman
brianteeman - comment - 29 Jul 2024

Thank you for your contribution @brianteeman! For now this is okay like this, in a future PR I would like to see this not restricted to just com_content, but to extend this to other components as well and make it a bit more flexible.

Thanks @Hackwar

It is not restricted to com_content as such it is just specific to com_content. It can be added to the two other core components that have a category view (newsfeeds and contacts) where it is even simpler as they only have a list view. I can submit a new PR if you wish for those components

avatar Hackwar
Hackwar - comment - 29 Jul 2024

I'd like to have a mechanism which allows also third party extensions which use com_categories to also use this.

avatar brianteeman
brianteeman - comment - 29 Jul 2024

I'd like to have a mechanism which allows also third party extensions which use com_categories to also use this.

Ah sorry - I misunderstood you. I think that's an easy fix to do - I will look at it once this has been merged

avatar Hackwar Hackwar - change - 29 Jul 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-07-29 15:35:39
Closed_By Hackwar
avatar Hackwar Hackwar - close - 29 Jul 2024
avatar Hackwar Hackwar - merge - 29 Jul 2024

Add a Comment

Login with GitHub to post a comment