User tests: Successful: Unsuccessful:
When introducing dark mode, a border was added to the tour popups so that the tours would be more visible in dark mode.
Unfortunately, this 'cuts' the arrows off the popup and no border was added to the arrows themselves so that they are not visible in dark mode.
This is the first attempt in fixing that.
Although this PR fixes the arrows, there is more to be done, particularly that the colors for the tour popups are too dark and barely pop over the content. Check PR#43854.
Run the welcome tour in light and dark mode and check that the arrows are showing properly.
A popup in light mode.
The popup border shows over the arrow and the arrow is not of the color of the header background.
A popup in dark mode.
The border cuts off the arrow from the popup and is barely visible.
A popup in light mode.
The border is gone and the arrow is of the right color.
A popup in dark mode.
The border no longer cuts off the arrow from the popup and the arrow is more visible.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change |
Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
I have tested this item ✅ successfully on da2ff39
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
RTC
|
My sincere apology, I did not refresh my page and did not see the latest test and RTC label.
I reverted the unnecessary change in background color of the popup header in favor of PR#43854.
The change in color was minimal (from black to a lighter dark color) and had no effect on the arrow fixes I made in this PR.
Therefore the tests, when focusing on the arrow fix alone, will return the same exact results. I let it to the discretion of the release managers to decide if the tests need to be redone or not.
(My initial thought was to remove the color change to avoid merge issues later on...)
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-09 08:25:18 |
Closed_By | ⇒ | pe7er |
I have tested this item ✅ successfully on da2ff39
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43825.