RTC NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
23 Jul 2024

Summary of Changes

When introducing dark mode, a border was added to the tour popups so that the tours would be more visible in dark mode.
Unfortunately, this 'cuts' the arrows off the popup and no border was added to the arrows themselves so that they are not visible in dark mode.

This is the first attempt in fixing that.

Although this PR fixes the arrows, there is more to be done, particularly that the colors for the tour popups are too dark and barely pop over the content. Check PR#43854.

Testing Instructions

Run the welcome tour in light and dark mode and check that the arrows are showing properly.

Actual result BEFORE applying this Pull Request

A popup in light mode.
The popup border shows over the arrow and the arrow is not of the color of the header background.

light_before

A popup in dark mode.
The border cuts off the arrow from the popup and is barely visible.

dark_before

Expected result AFTER applying this Pull Request

A popup in light mode.
The border is gone and the arrow is of the right color.

light_after

A popup in dark mode.
The border no longer cuts off the arrow from the popup and the arrow is more visible.

image

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar obuisard obuisard - open - 23 Jul 2024
avatar obuisard obuisard - change - 23 Jul 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2024
Category Repository NPM Change
avatar obuisard obuisard - change - 23 Jul 2024
The description was changed
avatar obuisard obuisard - edited - 23 Jul 2024
avatar obuisard obuisard - change - 23 Jul 2024
The description was changed
avatar obuisard obuisard - edited - 23 Jul 2024
avatar obuisard obuisard - change - 23 Jul 2024
The description was changed
avatar obuisard obuisard - edited - 23 Jul 2024
avatar obuisard obuisard - change - 23 Jul 2024
Labels Added: NPM Resource Changed PR-5.2-dev
avatar obuisard obuisard - change - 23 Jul 2024
The description was changed
avatar obuisard obuisard - edited - 23 Jul 2024
avatar obuisard obuisard - change - 23 Jul 2024
The description was changed
avatar obuisard obuisard - edited - 23 Jul 2024
avatar obuisard obuisard - change - 23 Jul 2024
The description was changed
avatar obuisard obuisard - edited - 23 Jul 2024
avatar obuisard obuisard - change - 23 Jul 2024
The description was changed
avatar obuisard obuisard - edited - 23 Jul 2024
avatar Quy Quy - test_item - 24 Jul 2024 - Tested successfully
avatar Quy
Quy - comment - 24 Jul 2024

I have tested this item ✅ successfully on da2ff39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43825.

avatar LadySolveig LadySolveig - test_item - 26 Jul 2024 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 26 Jul 2024

I have tested this item ✅ successfully on da2ff39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43825.

avatar Hackwar Hackwar - change - 26 Jul 2024
Status Pending Ready to Commit
avatar obuisard obuisard - change - 26 Jul 2024
Labels Added: RTC
avatar obuisard obuisard - change - 26 Jul 2024
The description was changed
avatar obuisard obuisard - edited - 26 Jul 2024
avatar obuisard
obuisard - comment - 26 Jul 2024

My sincere apology, I did not refresh my page and did not see the latest test and RTC label.
I reverted the unnecessary change in background color of the popup header in favor of PR#43854.
The change in color was minimal (from black to a lighter dark color) and had no effect on the arrow fixes I made in this PR.
Therefore the tests, when focusing on the arrow fix alone, will return the same exact results. I let it to the discretion of the release managers to decide if the tests need to be redone or not.
(My initial thought was to remove the color change to avoid merge issues later on...)

avatar pe7er pe7er - change - 9 Aug 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-09 08:25:18
Closed_By pe7er
avatar pe7er pe7er - close - 9 Aug 2024
avatar pe7er pe7er - merge - 9 Aug 2024
avatar pe7er
pe7er - comment - 9 Aug 2024

Thanks @obuisard !

Add a Comment

Login with GitHub to post a comment