[#43823] - [5.2] [feature] Media manager select last uploaded item (iframe)
- Fixed in Code Base
- 26 Jul 2024
- Medium
- Build: 5.2-dev
- # 43823
- Diff
- dgrammatiko:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Select the last uploaded file when media manager is inside an iframe (ie, when selecting an image in a media field or inside an editor)
Testing Instructions
- Create a new article
- Select an intro image
- navigate to any folder
- Upload an image
The image should be selected
Repeat the same with the CMS Content->Media button in tinyMCE editor
Repeat the same with the media button bellow the Codemirror
Actual result BEFORE applying this Pull Request
The file was not selected after upload, user needed to pick the file manually
Expected result AFTER applying this Pull Request
The file is selected after upload, user needed to pick the file manually
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
Clicking Select or Insert Media button does not insert the image. You have to reselect the image, then the button will work.
What's your browser? Seems to work on Webkit (I only tested it there)
Firefox 128.0 and Chrome Version 126.0.6478.128 on Windows
I have tested this item ? unsuccessfully on b3c304d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.
@dgrammatiko User selection happen on click, then that "select event" is triggered
| Labels |
Added:
Feature
|
||
User selection happen on click, then that "select event" is triggered
I'm NOT doing an automatic insertion of the uploaded image, I just set the state of the selected file! (means the user still needs to press the insert button, but in this case the file is already selected no need to search for it...) BTW the issue was about SELECTING the image not automatically inserting it, that's a different case
@Quy @brianteeman should be ok for all browsers now (tested with Chrome, Webkit, FF)
I have tested this item ✅ successfully on f669b9f
works as intended now - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.
I have tested this item ✅ successfully on f669b9f
Thank you!!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on d357b4c
Tested image in editor and intro image. Also with the DPMedia restricted plugin.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.
@Quy @brianteeman could you test this again? There were some changes lately and we are missing one more test.
I have tested this item ✅ successfully on 0d98552
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-26 17:27:55 |
| Closed_By | ⇒ | Hackwar |
Thank you for your contribution @dgrammatiko! ?
Clicking
SelectorInsert Mediabutton does not insert the image. You have to reselect the image, then the button will work.