RTC bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
23 Jul 2024

Pull Request for Issue #43797 .

Summary of Changes

Do not force Product schema for every article
Revert #42934

Testing Instructions

Review

Actual result BEFORE applying this Pull Request

Product schema added to every article with Vote enabled

Expected result AFTER applying this Pull Request

No product schema

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 23 Jul 2024
avatar Fedik Fedik - change - 23 Jul 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2024
Category Front End Plugins
avatar Fedik Fedik - change - 23 Jul 2024
The description was changed
avatar Fedik Fedik - edited - 23 Jul 2024
avatar Quy Quy - test_item - 23 Jul 2024 - Tested successfully
avatar Quy
Quy - comment - 23 Jul 2024

I have tested this item ✅ successfully on ec7a482


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43827.

avatar viocassel viocassel - test_item - 23 Jul 2024 - Tested successfully
avatar viocassel
viocassel - comment - 23 Jul 2024

I have tested this item ✅ successfully on ec7a482


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43827.

avatar Quy Quy - change - 23 Jul 2024
Status Pending Ready to Commit
Labels Added: bug PR-4.4-dev
avatar Quy
Quy - comment - 23 Jul 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43827.

avatar Slava287
Slava287 - comment - 23 Jul 2024

Thanks, will this be fixed in future updates?

avatar bembelimen
bembelimen - comment - 23 Jul 2024

Do we now have Google complaining again?

avatar brianteeman
brianteeman - comment - 24 Jul 2024

If this is a full revert then the original issue will be present so that will still need to be fixed

avatar Fedik
Fedik - comment - 24 Jul 2024

Yes, but that is less critical than this one. I think

avatar laoneo laoneo - change - 6 Aug 2024
Labels Added: RTC
avatar laoneo laoneo - change - 6 Aug 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-06 13:44:48
Closed_By laoneo
avatar laoneo laoneo - close - 6 Aug 2024
avatar laoneo laoneo - merge - 6 Aug 2024
avatar laoneo
laoneo - comment - 6 Aug 2024

Merging this as it is done properly in #42933. Thanks for the help @Fedik.

Add a Comment

Login with GitHub to post a comment