[#43791] - [5.1] Fix Fontend language multilingual without compatibility plugin
- Fixed in Code Base
- 26 Jul 2024
- Medium
- Build: 5.1-dev
- # 43791
- Diff
- bembelimen:fontend-language-multilingual
User tests: Successful: Unsuccessful:
Summary of Changes
Fix wrong field name for multilingual sites in user profile
Testing Instructions
- Disable the "Behaviour - Backward Compatibility" plugin
- Enable the "System - Language Filter" plugin
- Check User profile (frontend/backend)
Actual result BEFORE applying this Pull Request
- Language field is a text field
Expected result AFTER applying this Pull Request
- Language field is a select
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Front End |
@bembelimen Do you know what this is good for, and is it somehow related to the issue? https://github.com/joomla/joomla-cms/blob/4.4-dev/libraries/src/Form/Field/FrontendlanguageField.php#L26-L32
I have tested this item ✅ successfully on a1a927a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43791.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43791.
@bembelimen Do you know what this is good for, and is it somehow related to the issue? https://github.com/joomla/joomla-cms/blob/4.4-dev/libraries/src/Form/Field/FrontendlanguageField.php#L26-L32
Should not have any effect on it
@bembelimen Do you know what this is good for, and is it somehow related to the issue? https://github.com/joomla/joomla-cms/blob/4.4-dev/libraries/src/Form/Field/FrontendlanguageField.php#L26-L32
Should not have any effect on it
@bembelimen Should it be changed to public $type = 'Frontendlanguage'; in 6.0-dev so it is like for the other fields? Or should that $type variable be deprecated for all fields because it has no effect at all?
@bembelimen Do you know what this is good for, and is it somehow related to the issue? https://github.com/joomla/joomla-cms/blob/4.4-dev/libraries/src/Form/Field/FrontendlanguageField.php#L26-L32
Should not have any effect on it
@bembelimen Should it be changed to
public $type = 'Frontendlanguage';in 6.0-dev so it is like for the other fields? Or should that$typevariable be deprecated for all fields because it has no effect at all?
it confused me
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-26 16:54:42 |
| Closed_By | ⇒ | LadySolveig |
Thanks @bembelimen and also for testing and review @brianteeman @dautrich @richard67
I have tested this item ✅ successfully on a1a927a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43791.