User tests: Successful: Unsuccessful:
This is an effort to remove deprecated code from the system. The Installer class depends on the Adapter class, which in turn has been deprecated for a long time already. This PR removes the code of the Adapter class from the Installer class and replaces it with some sane methods to add adapters when required.
This PR does some cleanup and it adds the following methods:
I reused some method names from the Adapter class. This PR is a b/c break and thus targeted towards 6.0.
php cli/joomla.php extension:install
)There should be no difference between before and after applying the change and the extension should be installed like normal.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: joomla/Manual#301
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_joomlaupdate Libraries |
Labels |
Added:
b/c break
PR-6.0-dev
|
Labels |
Added:
Documentation Required
|
Labels |
Added:
Feature
|
I fixed the issue. Could you please test again?
I have tested this item ✅ successfully on c4bba80
Re-Tested with fresh 6.0-dev branch plus gh pr checkout 43792
in local installation on macOS, PHP 8.4.5 with module zitat-service.de
php cli/joomla.php extension:install --path ~/Downloads/mod_zitat_service_de_2.0.3.zip
php cli/joomla.php extension:install --url https://github.com/muhme/quote_joomla/releases/download/2.0.3/mod_zitat_service_de_2.0.3.zip
I have tested this item ✅ successfully on 870546b
Tested and works both ways.
I've restored @muhme 's test result in the issue tracker because the commit which has invalidated the human tests count was just a clean branch update.
@Bodge-IT Please, when doing branch updates which are clean, i.e. not had conflicts to be resolved, then restore any previous human tests in the issue tracker by using the "Alter test" button.
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-06-11 07:19:48 |
Closed_By | ⇒ | Bodge-IT | |
Labels |
Added:
RTC
|
Thank you!!!
I have tested this item 🔴 unsuccessfully on ce7745c
Tested on 6.0-dev branch with local installation on macOS, PHP 8.4.5 with module zitat-service.de
Before applying the PR
php cli/joomla.php extension:install --url
and uninstalledphp cli/joomla.php extension:install --path
and uninstalledApplied the patch by
gh pr checkout 43792 && brew services restart httpd
php cli/joomla.php extension:install --url https://github.com/muhme/quote_joomla/releases/download/2.0.3/mod_zitat_service_de_2.0.3.zip
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43792.