[#43790] - MFA and Silent Logins
- Closed
- 15 Jul 2024
- Medium
- Build: 5.2-dev
- # 43790
- Diff
- leeroy1821:patch-2
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42308 .
Summary of Changes
Update \Joomla\Plugin\System\Webauthn\PluginTraits\AjaxHandlerLogin. Fix loading user plugins (broken because maybe a b/c break?). Fix wrong events constructors (missing subject, wrong argument order). Fix triggering events (wrong event name passed).
Testing Instructions
- Create user with MFA and passkey login
- Users, Manage, Options, Multi-factor Authentication, Multi-factor Authentication after silent login => No.
- Log out
- Log in with passkey
Actual result BEFORE applying this Pull Request
Joomla! asks for MFA
Expected result AFTER applying this Pull Request
Joomla does not ask for MFA
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
@richard67 I had already made a PR for 5.2-dev. Should I close it and open for 5.1-dev?
@richard67 I had already made a PR for 5.2-dev. Should I close it and open for 5.1-dev?
@leeroy1821 Yes. I've tried to rebase your 5.2-dev PR to 5.1-dev, but that failed, so I've reverted it. Would be good if you could redo it for 5.1-dev. Thanks in advance.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-15 12:13:20 |
| Closed_By | ⇒ | leeroy1821 | |
| Labels |
Added:
PR-5.2-dev
|
||
@leeroy1821 As it's a bug which exists in 5.0 and 5.1 the PR should be made for the 5.1-dev branch.