NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
12 Jul 2024

Pull Request for Issue # .

Summary of Changes

  • Move tools and source JS to ESM
  • ES6 files have now the extension .mjs (used to be .es6.js)
  • Web Components also have .mjs extension (used to be .w-c.es6.js)
  • The build/media_source/system/js/joomla-core-loader.mjs file now includes the required css and the related build/media_source/system/scss/joomla-core-loader.scss is deleted

Testing Instructions

You need Git and NPM to test this

Pull the 4.4-dev branch and run:

  • npm install
  • npm run gzip
  • npm run versioning
  • Store the media folder somewhere outside of the joomla-cms folder

Pull this PR gh pr checkout 43779 and run:

  • npm install
  • npm run gzip
  • npm run versioning
  • Store the media folder somewhere outside of the joomla-cms folder

Compare the two folders. The only difference should be the missing files: media/system/css/joomla-core-loader.css, media/system/css/joomla-core-loader.min.css, media/system/css/joomla-core-loader.min.css.gz

Check that basic backend functionality

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik @richard67 could you please test this one (pretty hard for the average tester)?

@LadySolveig @bembelimen please DO NOT upmerge this, I will do a PR on the 5.1 instead

avatar dgrammatiko dgrammatiko - open - 12 Jul 2024
avatar dgrammatiko dgrammatiko - change - 12 Jul 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jul 2024
Category JavaScript Administration com_media NPM Change Repository
61afefa 12 Jul 2024 avatar dgrammatiko build
avatar dgrammatiko dgrammatiko - change - 12 Jul 2024
Labels Added: NPM Resource Changed PR-4.4-dev
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jul 2024
Category JavaScript Administration com_media NPM Change Repository JavaScript Administration com_media NPM Change
8bfea31 12 Jul 2024 avatar dgrammatiko cs
0f3b0f2 12 Jul 2024 avatar dgrammatiko CS
ee2eb85 12 Jul 2024 avatar dgrammatiko CS
f76e081 12 Jul 2024 avatar dgrammatiko CS
ad5ef98 12 Jul 2024 avatar dgrammatiko CS
avatar dgrammatiko dgrammatiko - change - 12 Jul 2024
The description was changed
avatar dgrammatiko dgrammatiko - edited - 12 Jul 2024
avatar dgrammatiko dgrammatiko - change - 12 Jul 2024
The description was changed
avatar dgrammatiko dgrammatiko - edited - 12 Jul 2024
avatar dgrammatiko dgrammatiko - change - 12 Jul 2024
The description was changed
avatar dgrammatiko dgrammatiko - edited - 12 Jul 2024
avatar Fedik
Fedik - comment - 13 Jul 2024

Thanks for the work.

I do not like renaming under /media_source. We do not have actual modules there, only regular scripts. I would call .mjs only for scripts that actualy use ESM (have export or import in it) There only few of then (even web components not really utilise it). Personaly I would not bother with it.
But I don't mind, if release managers decide to accept it.

For the build script it looks much better there. Because there is actual ESM now.

avatar dgrammatiko
dgrammatiko - comment - 13 Jul 2024

For the build script it looks much better there. Because there is actual ESM now.

@Fedik it's just a convention, but now we have way less options, which, normally, should be easier for every contributor

avatar Fedik
Fedik - comment - 13 Jul 2024

should be easier for every contributor

yeah

e9149c7 16 Jul 2024 avatar dgrammatiko fix
avatar Fedik Fedik - test_item - 17 Jul 2024 - Tested successfully
avatar Fedik
Fedik - comment - 17 Jul 2024

I have tested this item ✅ successfully on 6b3316b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43779.

avatar laoneo
laoneo - comment - 24 Jul 2024

Thanks for your hard work on this. Unfortunately 4.4 is in maintenance mode, where we merge mainly bug fixes. To not risk to have the 4.4-dev unstable and prevent side effects in the ecosystem, I'm closing this one for now as the move to ESM should be done in an active development branch, which is currently 5.2. Thanks for understanding.

avatar laoneo laoneo - close - 24 Jul 2024
avatar laoneo laoneo - change - 24 Jul 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-07-24 18:04:06
Closed_By laoneo
avatar dgrammatiko
dgrammatiko - comment - 24 Jul 2024

@laoneo the only reason I backported the changes was to make it easier for devs when they'll have to push a change from 4.4 to 5/6. Anyways np

Add a Comment

Login with GitHub to post a comment