User tests: Successful: Unsuccessful:
Pull Request for Issue # .
.mjs
(used to be .es6.js
).mjs
extension (used to be .w-c.es6.js
)build/media_source/system/js/joomla-core-loader.mjs
file now includes the required css and the related build/media_source/system/scss/joomla-core-loader.scss
is deletedYou need Git and NPM to test this
Pull the 4.4-dev
branch and run:
npm install
npm run gzip
npm run versioning
joomla-cms
folderPull this PR gh pr checkout 43779
and run:
npm install
npm run gzip
npm run versioning
joomla-cms
folderCompare the two folders. The only difference should be the missing files: media/system/css/joomla-core-loader.css
, media/system/css/joomla-core-loader.min.css
, media/system/css/joomla-core-loader.min.css.gz
Check that basic backend functionality
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@Fedik @richard67 could you please test this one (pretty hard for the average tester)?
@LadySolveig @bembelimen please DO NOT upmerge this, I will do a PR on the 5.1 instead
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Administration com_media NPM Change Repository |
Labels |
Added:
NPM Resource Changed
PR-4.4-dev
|
Category | JavaScript Administration com_media NPM Change Repository | ⇒ | JavaScript Administration com_media NPM Change |
should be easier for every contributor
yeah
I have tested this item ✅ successfully on 6b3316b
Thanks for your hard work on this. Unfortunately 4.4 is in maintenance mode, where we merge mainly bug fixes. To not risk to have the 4.4-dev unstable and prevent side effects in the ecosystem, I'm closing this one for now as the move to ESM should be done in an active development branch, which is currently 5.2. Thanks for understanding.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-24 18:04:06 |
Closed_By | ⇒ | laoneo |
Thanks for the work.
I do not like renaming under
/media_source
. We do not have actual modules there, only regular scripts. I would call.mjs
only for scripts that actualy use ESM (haveexport
orimport
in it) There only few of then (even web components not really utilise it). Personaly I would not bother with it.But I don't mind, if release managers decide to accept it.
For the build script it looks much better there. Because there is actual ESM now.