Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#43745] - [5.1] Field ModalSelect: make sure token in the URLs

RTC NPM Resource Changed bug PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
6 Jul 2024

Pull Request for Issue # .

Summary of Changes

Fix for the ModalSelect field, always add the token to the urls.

Testing Instructions

Run npm install

Add ModalSelect field in to Custom HTML module XML:

<field
  type="ModalSelect"
  name="article"
  label="Article"

  select="true"
  titleSelect="Selecting the Article"
  urlSelect="index.php?option=com_content&amp;view=articles&amp;layout=modal&amp;tmpl=component"
  clear="true"
/>

Then open Custom HTML module editing on the site (not administrator). And try to select the article, using "select" button.

Actual result BEFORE applying this Pull Request

An error, kind of "wrong token"

Expected result AFTER applying this Pull Request

All works, you should be able to select the article

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 6 Jul 2024
avatar Fedik Fedik - change - 6 Jul 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2024
Category ⇒ JavaScript Repository NPM Change
avatar Fedik Fedik - change - 6 Jul 2024
The description was changed
avatar Fedik Fedik - edited - 6 Jul 2024
avatar Fedik Fedik - change - 6 Jul 2024
Labels Added: NPM Resource Changed bug PR-5.1-dev
avatar Fedik Fedik - change - 6 Jul 2024
The description was changed
avatar Fedik Fedik - edited - 6 Jul 2024
avatar Quy Quy - test_item - 9 Jul 2024 - Tested successfully
avatar Quy
Quy - comment - 9 Jul 2024

I have tested this item ✅ successfully on 9b02403

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745.

avatar viocassel viocassel - test_item - 10 Jul 2024 - Tested successfully
avatar viocassel
viocassel - comment - 10 Jul 2024

I have tested this item ✅ successfully on 9b02403

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745.

avatar Quy Quy - change - 10 Jul 2024
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 10 Jul 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745.

avatar Quy Quy - change - 10 Jul 2024
Labels Added: RTC
avatar robbiejackson robbiejackson - test_item - 25 Jul 2024 - Tested successfully
avatar robbiejackson
robbiejackson - comment - 25 Jul 2024

I have tested this item ✅ successfully on 1b734cd

Test form now works well on the site front-end.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745.

avatar LadySolveig LadySolveig - alter_testresult - 26 Jul 2024 - Quy: Tested successfully
avatar LadySolveig LadySolveig - alter_testresult - 26 Jul 2024 - viocassel: Tested successfully
avatar LadySolveig LadySolveig - close - 26 Jul 2024
avatar LadySolveig LadySolveig - merge - 26 Jul 2024
avatar LadySolveig LadySolveig - change - 26 Jul 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-07-26 17:22:51
Closed_By ⇒ LadySolveig
avatar LadySolveig
LadySolveig - comment - 26 Jul 2024

Thank you @Fedik and also for testing @Quy @viocassel @robbiejackson !

Add a Comment

Login with GitHub to post a comment