No Code Attached Yet
avatar brianteeman
brianteeman
4 Jul 2024

The version in package,json should match the version in package-lock.json

"version": "5.1.2",

"version": "5.1.1",

avatar brianteeman brianteeman - open - 4 Jul 2024
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 4 Jul 2024
avatar brianteeman
brianteeman - comment - 8 Jul 2024

RC2 has now been released with the same error

avatar brianteeman
brianteeman - comment - 9 Jul 2024

why do we bother to test and report things

avatar rdeutz rdeutz - change - 9 Jul 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-07-09 14:18:38
Closed_By rdeutz
avatar rdeutz rdeutz - close - 9 Jul 2024
avatar rdeutz
rdeutz - comment - 9 Jul 2024

It's not an error. The lock file is changed when we do package updates, obviously this wasn't the case for 5.1.2. Another situation when the lock file is updated is when a package is published. We are not doing this and it is not needed.

We could delete the file and make npn install, that would create a new lock file with the current joomla version. Or we delete the version from package.json, it is not really needed. We will discuss this at the next Maintainers Meeting.

avatar brianteeman
brianteeman - comment - 9 Jul 2024

clearly you are incorrect Robert or it would not have been silently updated

"version": "5.1.2",

avatar LadySolveig
LadySolveig - comment - 10 Jul 2024

Just for you, to make you happy ? @brianteeman

avatar rdeutz
rdeutz - comment - 10 Jul 2024

clearly you are incorrect Robert or it would not have been silently updated

no I am not, anything I have written was correct

avatar brianteeman
brianteeman - comment - 10 Jul 2024

Just for you, to make you happy ? @brianteeman

thank you.

Add a Comment

Login with GitHub to post a comment