[#43740] - [4.4] Fix display of total votes
- Fixed in Code Base
- 10 Jul 2024
- Medium
- Build: 4.4-dev
- # 43740
- Diff
- Quy:43728-show-total-votes
User tests: Successful: Unsuccessful:
Pull Request for Issue #43728. Regression of #42934.
Summary of Changes
Move the number of votes outside of the visually-hidden section so it can be visible.
Testing Instructions
Enable Voting in Articles component configuration.
Vote for one or more articles.
Edit Content -Vote plugin.
Toggle Number of Votes to Show.
Actual result BEFORE applying this Pull Request
Total number of votes is not visible.
Expected result AFTER applying this Pull Request
Total number of votes is visible.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
bug
PR-4.4-dev
|
||
I have tested this item ✅ successfully on 9ed4867
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43740.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43740.
The whole block after
<?php if ($rcount) : ?>needs to be indented
How can this be rtc while this is still outstanding to be fixed
The whole block after
<?php if ($rcount) : ?>needs to be indentedHow can this be rtc while this is still outstanding to be fixed
To me the code style seems to be ok, and PHPCS seems to be ok with it, too.
Thanks for this PR and testing.
Just a question. Who or what ensures that this PR also applies to J5?
The whole block after
<?php if ($rcount) : ?>needs to be indentedHow can this be rtc while this is still outstanding to be fixed
To me the code style seems to be ok, and PHPCS seems to be ok with it, too.
when you look at the entire file (not just the snippet shown in github) then you can see that @chmst is correct
| Labels |
Added:
RTC
|
||
@Quy Thanks for fixing the CS.
Leaving RTC status as the change after setting RTC was just a code style change, so previous human tests are still valid.
@chmst Thanks for review, and thanks @ChristineWk and @viocassel for testing.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-10 19:45:24 |
| Closed_By | ⇒ | MacJoom |
Thank you!
I have tested this item ✅ successfully on 9ed4867
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43740.