Feature RTC Unit/System Tests Language Change NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
3 Jul 2024

Pull Request for Issue #43404 .

Summary of Changes

This PR is a follow-up of #43610 that was closed some days ago.

I did several changes to the code, added some parameters (for layout) and functions (include specific articles by ID) and created a CSS file to control the layout. After this get merged additional changes in the CSS from Cassiopeia can be done.

Testing Instructions

I you don't directly install the PR package, you will need to run npm (npm run build:css) to get the CSS file.

With this module you can replace the existing mod_articles_xx. All you need is to play with the parameters.

Articles - Archived -> Filter Archived Articles only
Articles - Category -> Select category, play with parameter, use filter, group them, etc.
Articles - Latest -> Change ordering to newest first
Articles - Most Read -> Change ordering to hits
Articles - Newsflash -> Select category, play with parameter, use filter, group them, etc.

Toggle the inline help to get more information about some fields.

Expected result AFTER applying this Pull Request

Screenshot 2024-07-03 at 12-13-02 Typography

Screenshot 2024-07-03 at 12-13-22 Home

Screenshot 2024-07-03 at 12-14-06 Home

Screenshot 2024-07-03 at 13-37-26 Typography

Screenshot 2024-07-03 at 12-11-24 Joomla

Screenshot 2024-07-03 at 12-12-04 Joomla

Screenshot 2024-07-03 at 12-12-31 Typography

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar drmenzelit drmenzelit - open - 3 Jul 2024
avatar drmenzelit drmenzelit - change - 3 Jul 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2024
Category SQL Administration com_admin Postgresql Repository NPM Change Installation Language & Strings Libraries Modules Front End
avatar drmenzelit drmenzelit - change - 3 Jul 2024
Labels Added: Language Change NPM Resource Changed PR-5.2-dev
avatar brianteeman
brianteeman - comment - 3 Jul 2024

Layout horizontal only works in some module positions. Is this intentional? Took me a while to work out why i couldnt get the columns to work

avatar drmenzelit
drmenzelit - comment - 3 Jul 2024

Layout horizontal only works in some module positions. Is this intentional? Took me a while to work out why i couldnt get the columns to work

No, no intentional at all... But the number of columns is related to the width of the container (maybe something for the description of the field). For example you can set 3 columns and in main-bottom you will get 2, because the container is smaller than 992px

avatar drmenzelit drmenzelit - change - 3 Jul 2024
The description was changed
avatar drmenzelit drmenzelit - edited - 3 Jul 2024
avatar brianteeman
brianteeman - comment - 3 Jul 2024

The label "card style" confused me - I thought it referred to placing a border around the article. Not that it made the entire article a link,

When Card style is enable you should not be able to make the category a link as it will never work.

Same is true for the tags

avatar brianteeman
brianteeman - comment - 3 Jul 2024

Articles Info Layout

I think it makes more sense to describe this as single line and multiline as opposed to horizontal and vertical

avatar drmenzelit
drmenzelit - comment - 3 Jul 2024

I think it makes more sense to describe this as single line and multiline as opposed to horizontal and vertical

Good idea! Thank you

avatar brianteeman
brianteeman - comment - 3 Jul 2024

No matter what options you chose it is always output as a list. When you just have the article titles that makes sense but I dont believe it is correct to display articles with content in this way and it should be a div. We dont display a content blog view as a list

avatar drmenzelit
drmenzelit - comment - 3 Jul 2024

The label "card style" confused me - I thought it referred to placing a border around the article. Not that it made the entire article a link,

I understand card style as a combination of the two things. I was not sure, if it is good to put so much css on the module itself and better do it in Cassiopeia (as is now in the case of mod_articles_newsflash).

When Card style is enable you should not be able to make the category a link as it will never work.

Same is true for the tags

That is true ... Maybe it will be better to remove the possibility to display category and tags if card style is selected ... It is always difficult to get all ideas working well (and I have a lot of other ideas ;-) )

avatar drmenzelit
drmenzelit - comment - 3 Jul 2024

No matter what options you chose it is always output as a list. When you just have the article titles that makes sense but I dont believe it is correct to display articles with content in this way and it should be a div. We dont display a content blog view as a list

I was following a tutorial for accessible cards: https://gehirngerecht.digital/barrierefreie-cards-erstellen-schritt-fuer-schritt-anleitung/
They write: "A list is an advantage for screen readers because, among other things, it tells them how many elements to expect. "

avatar drmenzelit drmenzelit - change - 3 Jul 2024
Labels Added: Feature
avatar brianteeman
brianteeman - comment - 3 Jul 2024

They write: "A list is an advantage for screen readers because, among other things, it tells them how many elements to expect.

That's true but it would also be true for all the blog article views. For me it is an abuse of the list semantics

avatar brianteeman
brianteeman - comment - 3 Jul 2024

Show Introtext
image

I suggest making this default to Show. Otherwise it is very confusing when you change Titles Only to No and you still dont see the introtext
image

avatar brianteeman
brianteeman - comment - 3 Jul 2024

Articles Info Layout showon syntax is not correct

showon="title_only:0[AND]show_date:1[OR]show_category:1[OR]show_hits:1[OR]show_author:1"

It should not be displayed when title only = 1

image

avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2024
Category SQL Administration com_admin Postgresql Repository NPM Change Installation Language & Strings Libraries Modules Front End SQL Administration com_admin Postgresql Repository NPM Change Installation Language & Strings Libraries Modules Front End JavaScript Unit Tests
avatar chmst
chmst - comment - 5 Jul 2024

I suggest some descriptions for params. There are several params

"..... filtering type" with selection inclusive / exclusive.

This is not self explaining, I have to check the code for unterstanding. Maybe due to language gap?

When we started with J4, we had the rule that labels on switches should be only yes/no or show/hide. There were only a few rare exceptions, for example the user state. In this module we have more exceptions. Woudn't it be better to make a selection dropdown if alternatives are other that yes/no or show/hide?

avatar brianteeman
brianteeman - comment - 5 Jul 2024

When we started with J4, we had the rule that labels on switches should be only yes/no or show/hide. There were only a few rare exceptions, for example the user state. In this module we have more exceptions. Woudn't it be better to make a selection dropdown if alternatives are other that yes/no or show/hide?

agreed

avatar drmenzelit
drmenzelit - comment - 6 Jul 2024

When we started with J4, we had the rule that labels on switches should be only yes/no or show/hide.

Oh, I didn't know (or I forgot it). I will change to select lists.

avatar chmst
chmst - comment - 6 Jul 2024

Oh, I didn't know (or I forgot it).

Never mind. There was no document or written rule, only discussions. Because with switches the user cannot see the possible options.
We could add this as "best practice rule" to the manual.

avatar drmenzelit drmenzelit - change - 6 Jul 2024
Labels Added: Unit/System Tests
avatar brianteeman
brianteeman - comment - 7 Jul 2024

The article info data should be presented using the description element just as it is in the content component and not as a regular list element

avatar drmenzelit
drmenzelit - comment - 7 Jul 2024

The article info data should be presented using the description element just as it is in the content component and not as a regular list element

A description list needs <dt> and <dd> and at the moment we are only displaying the descripton but not the term.

  • Option 1: always display the term
  • Option 2: always make the term "visually hidden"
  • Option 3: add a parameter show / hide term
avatar brianteeman
brianteeman - comment - 7 Jul 2024

well it should be the same as with an article

avatar chmst
chmst - comment - 7 Jul 2024

I like the choice linline / vertical for the info-data elements - and would like to have this also for articles.

Could we make that like in my PR, #43729
with a visually hidden <dl><dt> label and the inline / vertical display for <dd>?

avatar Hackwar
Hackwar - comment - 22 Jul 2024

Can you help me get up to speed? I don't yet know the status of this PR. What still needs to be done? What is missing? Where do you need help?

Looking at this right now, I would like to have this in the testing sampledata and if this is supposed to be the future, then we should directly replace all cases of the old modules in our sampledata plugins with this new plugin and ideally you shouldn't see the difference...

avatar brianteeman
brianteeman - comment - 22 Jul 2024

Can you help me get up to speed? I don't yet know the status of this PR. What still needs to be done? What is missing? Where do you need help?

Looking at this right now, I would like to have this in the testing sampledata and if this is supposed to be the future, then we should directly replace all cases of the old modules in our sampledata plugins with this new plugin and ideally you shouldn't see the difference...

this is supposed to exist in parallel with the other content modules - otherwise we are in migration hell

avatar Hackwar
Hackwar - comment - 22 Jul 2024

We've had these modules for at least 10 years, most likely even since Mambo times, so of course we wont be dropping them like hot potatoes. I don't see them being replaced anytime soon, so at least until the end of 8.x I would expect the old ones to be safe. However, that still doesn't mean that we shouldn't be encouraging people to use the new module instead of the old ones. If the new module is only supposed to be used in parallel with the old ones, but feature-wise is identical, then we don't need this module. We think that this new module should be the future for com_content modules, so we should advertise it in our core product by using it as a direct replacement for the old ones in our sampledata.

avatar brianteeman
brianteeman - comment - 22 Jul 2024

its easy to update the sample data - shouldnt take more than a few minutes

avatar joomla-cms-bot joomla-cms-bot - change - 8 Aug 2024
Category SQL Administration com_admin Postgresql Repository NPM Change Installation Language & Strings Libraries Modules Front End JavaScript Unit Tests SQL Administration com_admin Postgresql Repository NPM Change Installation Language & Strings Libraries Modules Front End Plugins JavaScript Unit Tests
avatar drmenzelit
drmenzelit - comment - 8 Aug 2024

I have modified the Blog Sample Data to display the new module instead of the old ones. The Testing Sample Data need a complete restructuring and I'm not sure if I'm able to do that.

avatar HDInfautre
HDInfautre - comment - 8 Aug 2024

Hello
about installing a PR
I installed this PR with the 2nd method by downloading https://artifacts.joomla.org/drone/j...te_Package.zip then doing the manual update which asks me to identify myself on the site.
I had already tried by copying the update url and putting development version without success
So I easily went from the test version joomla 5.2alpha3 to this version joomla 5.2alpha3+PR new module
It's easier than going through the component whose options I got lost in by using it once a year.

For the future, I have 2 questions,
a) when I install another more recent version, if this pr is not included, what I did will be overwritten?
b) if I put another joomla 5.2x + PR, it will not overwrite and a priori should not interfere?

About the module
Good to know you must set display options correctly" otherwise there is no display
I appreciate

  • the presentation on the same line. I imagine that after the templates including astroid will be able to create a nice layout :-)
  • the fact of clicking on a block

Afterwards I have 2 questions
c) it seems that the images are not rendered! yet I put 2 nice images in the content of the text.
Well it is less important for me because I systematically use the Tassos custom field images which will probably never be taken natively in this module
d) I have not seen any repercussions of modifying the parameter: "Articles Info Layout​"

Sorry if my bad English is poorly translated.

avatar drmenzelit
drmenzelit - comment - 8 Aug 2024

@HDInfautre sorry I don't understand your problems / questions about the installation ...

Article Info Layout = Multiline
grafik

Article Info Layout = Single Line
grafik

Article image: first image is intro image, secon one is an image inside the article (before the read more)
grafik

I have no idea what Astroid framework will do with this module ...

avatar HDInfautre
HDInfautre - comment - 8 Aug 2024

HI
hanks for this very quick response :-)
I'm giving up my positive remarks or on astroid.
I'm just focusing on the remarks
c) it seems that the images are not rendered!
https://j5test-seul.88h.ovh/index.php/test-mod yet I put 2 beautiful images in the text content.
Well it's less important for me because I systematically use the Tassos custom field images which will probably never be taken natively in this module
d) I have not seen any repercussions of modifying the parameter: "Articles Info Layout​"

After possibly on the questions concerning the post-patch updates if it's understandable!?

avatar brianteeman
brianteeman - comment - 8 Aug 2024

Make sure this setting is set to show
image

avatar drmenzelit
drmenzelit - comment - 8 Aug 2024

The images are not rendered because you have set a character limit for the introtext ... For my understanding that is correct, but maybe I need to change the visibility of the "Show Article Images" parameter...

You are showing only one element (category) from the article info that is why you don't see any difference between multiline and single line, try displaying the author too

avatar HDInfautre
HDInfautre - comment - 8 Aug 2024

HI
hanks for this very quick response :-)
I'm giving up my positive remarks or on astroid.
I'm just focusing on the remarks
c) it seems that the images are not rendered!
https://j5test-seul.88h.ovh/index.php/test-mod yet I put 2 beautiful images in the text content.
Well it's less important for me because I systematically use the Tassos custom field images which will probably never be taken natively in this module
d) I have not seen any repercussions of modifying the parameter: "Articles Info Layout​"

After possibly on the questions concerning the post-patch updates if it's understandable!?

The images are not rendered because you have set a character limit for the introtext ... For my understanding that is correct, but maybe I need to change the visibility of the "Show Article Images" parameter...

You are showing only one element (category) from the article info that is why you don't see any difference between multiline and single line, try displaying the author too

Hi
thanks for the follow-up
The image is at the beginning of the text
I checked what seems right to me.

I can give access if necessary.
scrnli_08_08_2024 19-30-46
Capture d’écran du 2024-08-08 19-30-16

avatar drmenzelit
drmenzelit - comment - 8 Aug 2024

Again: if you set a limit for the introtext the article images will not be rendered. I commited a new version of the module, I changed the parameter, "Show Article Images" will only be displayed if the introtext limit is set to 0 (not truncated)

avatar HDInfautre
HDInfautre - comment - 8 Aug 2024

Again: if you set a limit for the introtext the article images will not be rendered. I commited a new version of the module, I changed the parameter, "Show Article Images" will only be displayed if the introtext limit is set to 0 (not truncated)

OK, sorry, I misunderstood.
It works as expected, but as you can see from the result https://j5test-seul.88h.ovh/index.php/test-mod , I think people will prefer to have an image AND reduced text :-)
Otherwise I imagine you'd have to overload the image, which I'm not sure is possible for many people.
I'll be able to do it myself, because you're not going to support images in a custom field anyway?
Regards

avatar drmenzelit
drmenzelit - comment - 8 Aug 2024

You should use intro or full image from the article
And no, we can't support custom fields in the module, for that you will need an override

avatar HDInfautre
HDInfautre - comment - 9 Aug 2024

Hi
do you plan to put "deprecated" in the name of the old modules to avoid that people continue to use the old modules!?

avatar brianteeman
brianteeman - comment - 9 Aug 2024

Hi do you plan to put "deprecated" in the name of the old modules to avoid that people continue to use the old modules!?

why would you want to do that

avatar HDInfautre
HDInfautre - comment - 9 Aug 2024

why would you want to do that

Hey I expressed myself badly!?
The new module replaces the old ones in a much better way. The idea is that people after the release of Joomla 5.2 are encouraged to use the new module :-) and this sends a signal to people who pass by. I see this in Joomla extensions (Tassos) as well as other computer software

But of course, the old sites would use them for years and years

avatar coolcat-creations
coolcat-creations - comment - 16 Aug 2024

So soooo happy that #18455 is finally to become reality :-) Thank you so much @drmenzelit

avatar drmenzelit
drmenzelit - comment - 17 Aug 2024

Oh, I think I did a mistake in some commit ... the display options should be set to "Title Only (lists) = Yes". I corrected it now.

avatar JeffOnWire
JeffOnWire - comment - 18 Aug 2024

Hey there,

I'm working on documentation for this module. While testing I am noticing that when the Display Option Show Intro/Full Image is set to show an image, and the article has an image but no caption for that image, an error message appears at the top of the module.

For example, this Cradle Mountain article has no caption defined for either its intro or full image:

avatar drmenzelit
drmenzelit - comment - 19 Aug 2024

@JeffOnWire I can't reproduce the warnings. Can you please check the content of lines 281 and 288?

avatar HDInfautre HDInfautre - test_item - 19 Aug 2024 - Tested successfully
avatar HDInfautre
HDInfautre - comment - 19 Aug 2024

I have tested this item ✅ successfully on 56845d4

Hi
Already successfully tested with alpha3 following my comments on github.
I've just re-tested the package with the latest version.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43738.

avatar fgsw
fgsw - comment - 20 Aug 2024

With this module you can replace the existing mod_articles_xx.

This mean the 5 Article Modules you listed below? I tried to show related Articles but didn't get it to work.

avatar drmenzelit
drmenzelit - comment - 20 Aug 2024

@fgsw yes, only the listed ones. Articles Related is still an own module.

avatar exlemor exlemor - test_item - 20 Aug 2024 - Tested successfully
avatar exlemor
exlemor - comment - 20 Aug 2024

I have tested this item ✅ successfully on 56845d4

I have successfully tested this.

I will add these comments:

a. if I set the Category Filtering Type to Exclusive and I do NOT select a Category, I get results?
(i.e. I would have expected an error saying that I had not selected a category) - Viviana explained that this is taken from mod_articles_category and there is no error telling you you need to select a category but to me it feels inconsistent with the rest of Joomla so many in the future that could happen.

b. If you choose under Filtering Options: Archived Articles --> Only and you don't happen to have any the Module completely disappears vs showing the Module with a statement like: No articles to display. As per Viviana, the same behavior as the current Archived Articles module but again, it doesn't feel homogeneous will Joomla as a whole - hopefully in the future it will be updated/more homogeneous.

This is a GREAT module - great work by Viviana and Brian (and whomever else helped if anyone did), but as it has so many options, capabilities, it is a bit daunting so great documentation (or possibly additionally a Guided Tour as well) will be needed to make it easiest for users and to guarantee (wide) adoption.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43738.

avatar fgsw
fgsw - comment - 20 Aug 2024

Articles Related is still an own module.

@drmenzelit Thanks for the answer. Your PR makes Joomla easier to use.

avatar richard67 richard67 - alter_testresult - 20 Aug 2024 - HDInfautre: Tested successfully
avatar richard67 richard67 - alter_testresult - 20 Aug 2024 - exlemor: Tested successfully
avatar richard67 richard67 - change - 20 Aug 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 20 Aug 2024

I've restored the previous human test results in the issue tracker as the change which invalidated the test count was just a rename of the update SQL script for PostgreSQL, which does not have any functional impact as that is the only 5.2 update SQL yet so it would have run despite of the wrong year in the file name.

=> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43738.

avatar JeffOnWire
JeffOnWire - comment - 20 Aug 2024

@drmenzelit After further testing this is maybe not an issue that requires attention. I am able to fix the problem by opening an article for edit, then saving it without making any changes. Possibly the issue is related to sample data? (Perhaps the sample data has a null value for the captions, or the captions property is not initially defined in the database. Opening the article in the editor and saving it maybe updates the property in the database in a way that fixes the problem—if that makes any sense).

avatar brianteeman
brianteeman - comment - 20 Aug 2024

@JeffOnWire thats a bug - you should not need to do that - although I do understand why that works

avatar JeffOnWire
JeffOnWire - comment - 20 Aug 2024

@exlemor Notes that the Articles module disappears completely when there is no content, and this happens also with the Articles - Archive module. I noticed this as well and agree these modules should always appear with a "no articles to display" message.

avatar chmst
chmst - comment - 20 Aug 2024

Yes that's a bug in the sample data plugin. Please @JeffOnWire could you open the issue tracker and mark the test as "not successful"? Then it is no longer Ready To Commit (RTC) and @drmenzelit can work on it. Thank you for testing so carefully :)

avatar richard67 richard67 - change - 20 Aug 2024
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 20 Aug 2024

Back to pending due to previous comment.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43738.

avatar richard67
richard67 - comment - 20 Aug 2024

Yes that's a bug in the sample data plugin. Please @JeffOnWire could you open the issue tracker and mark the test as "not successful"? Then it is no longer Ready To Commit (RTC) and @drmenzelit can work on it. Thank you for testing so carefully :)

I've already removed RTC.

avatar JeffOnWire
JeffOnWire - comment - 20 Aug 2024

Here's what I've done just now to recreate the issue.

Saved configuration.php then removed it from the root.
Created a new database.
Opened the site in a browser and configured the site using the new database.
Logged in as admin.
From the administrator dashboard I see a Sample Data module.
Click on the first option to install Testing Sample Data
Install the Articles module and configure:

  • Title: Articles Module Test
  • Position: sidebar-right
  • Article IDs to Include: 11 and 25
  • Display Options > Show Intro/Full Image: Intro Image

And then viewing the homepage I see the errors:

2024-08-20_14-08-55

avatar drmenzelit
drmenzelit - comment - 21 Aug 2024

I have modified the Blog Sample Data to display the new module instead of the old ones. The Testing Sample Data need a complete restructuring and I'm not sure if I'm able to do that.

As I wrote before, I did not touched the Testing Sample Data Plugin and I'm not able to rewrite it.

I will try to reproduce the warnings, but if the problem comes from the Testing Sample Data Plugin, then someone else has to repair it.

avatar drmenzelit
drmenzelit - comment - 21 Aug 2024

The bug with the caption is related with the Testing Sample Data and not with this PR. The same problem appears with an Articles Newsflash module on a site with installed sample data
grafik

avatar chmst
chmst - comment - 21 Aug 2024

Testing sample data are not in scope for this PR, but we don't know if older content has empty values in images. Code Review looks good for me.

avatar drmenzelit
drmenzelit - comment - 21 Aug 2024

I modified the query to catch the possibility of a wrong set image caption. @HDInfautre , @exlemor , @JeffOnWire I will appreciate a new test from you :-)

avatar JeffOnWire
JeffOnWire - comment - 21 Aug 2024

@drmenzelit The error is gone. Everything looks fine to me.

avatar drmenzelit
drmenzelit - comment - 21 Aug 2024

@JeffOnWire can you please mark your test in the issue tracker? Thanks

avatar JeffOnWire JeffOnWire - test_item - 21 Aug 2024 - Tested successfully
avatar JeffOnWire
JeffOnWire - comment - 21 Aug 2024

I have tested this item ✅ successfully on 56845d4

The error messages I received before no longer appear. Module is working correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43738.

avatar JeffOnWire
JeffOnWire - comment - 23 Aug 2024

When I set the Filter Options to show featured articles, and set the Display Options to show Introtext (with Introtext Limit (Characters) set to 100 characters), the featured articles are displayed with all the article text (or up to the Read More placeholder if the article has one). Should the amount of text for featured articles be restricted to Introtext Limit (Characters) like any other article?

avatar RickR2H
RickR2H - comment - 24 Aug 2024

When I set the Filter Options to show featured articles, and set the Display Options to show Introtext (with Introtext Limit (Characters) set to 100 characters), the featured articles are displayed with all the article text (or up to the Read More placeholder if the article has one). Should the amount of text for featured articles be restricted to Introtext Limit (Characters) like any other article?

I could not reproduce this issue. Please check again and make sure you tell us how to reproduce this, so we can check/fix any issues.

avatar RickR2H RickR2H - change - 24 Aug 2024
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 24 Aug 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43738.

avatar brianteeman
brianteeman - comment - 24 Aug 2024

@RickR2H this should not be RTC until @JeffOnWire responds to your question

avatar RickR2H
RickR2H - comment - 24 Aug 2024

@brianteeman I later noticed that @JeffOnWire tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43738.

avatar drmenzelit drmenzelit - change - 24 Aug 2024
Labels Added: RTC
avatar drmenzelit
drmenzelit - comment - 24 Aug 2024

Merged the changes done by @bembelimen (thank you for cleaning the code) and corrected an error in the logic of displaying article imagas that was interfering with the truncation of the intro text.

avatar richard67
richard67 - comment - 24 Aug 2024

@drmenzelit Could you fix PHPCS errors reported here https://ci.joomla.org/joomla/joomla-cms/78353/1/7 ? Thanks in advance.

avatar drmenzelit
drmenzelit - comment - 24 Aug 2024

@richard67 I was on it, done ... I hope ;-)

avatar pcombet-adosis
pcombet-adosis - comment - 26 Aug 2024

Hello,
tested in Multilanguage environment (FR/ENG), very interesting feature. Works well. One notice : "Article IDs to Exclude" - I did not manage how to separate the differents articles, tested, comma (,), dash (-) ... until I saw the multiline icon to show it needs a carriage return. It would be nice just to add an info at the RollOver on the "Article IDs to Exclude" text which would say "article ID separated by a carriage return" .
Best
Philippe

avatar pcombet-adosis pcombet-adosis - test_item - 26 Aug 2024 - Tested successfully
avatar pcombet-adosis
pcombet-adosis - comment - 26 Aug 2024

I have tested this item ✅ successfully on 56845d4

Hello,
tested in Multilanguage environment (FR/ENG), very interesting feature. Works well. One notice : "Article IDs to Exclude" - I did not manage how to separate the differents articles, tested, comma (,), dash (-) ... until I saw the multiline icon to show it needs a carriage return. It would be nice just to add an info at the RollOver on the "Article IDs to Exclude" text which would say "article ID separated by a carriage return" .
Best
Philippe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43738.

avatar JeffOnWire
JeffOnWire - comment - 27 Aug 2024

@RickR2H I tested this morning and was unable to recreate the introtext issue I raised on August 23. I have no issues. Everything looks fine.

avatar JeffOnWire
JeffOnWire - comment - 27 Aug 2024

I'm working with Ordering Options today and may have another issue—order by alias seems to be ordering by title. Here's my setup:

Removed configuration.php from the root.
Created a new database, configured Joomla and logged in as admin.
From the administrator dashboard I see a Sample Data module. Installed Testing Sample Data
Created two new user accounts, for Arthur Able and Peter Petra.
Went to Content > Articles, sorted by ID ascending and edited articles with ID 1-6

  • Administrator Components (ID 1): Created by = Arthur Able; leave alias blank
  • Archive Module (ID 2): Alias = Barbara Brown
  • Article Categories Module (ID 3): Created by = Peter Petra; leave alias blank
  • Articles Category Module (ID 4): Alias = Eddie Earnest
  • Authentication (ID 5): No change (created by you); leave alias blank
  • Australian Parks (ID 6): Alias = Helen Hurry

Install the Articles module and configure:

Title: Articles Module Test
Articles to Display: 6
Position: sidebar-right
Article IDs to Include: 1,2,3,4,5,6 on separate lines

Display Options: Title Only = No; Author: Show

Ordering Options: Alias Ascending (and switched back and forth between Ascending and Descending while testing)

I'm observing that the articles are always ordered by Title, regardless of the Author or Alias value.

Question about how Author and Alias

In Display Options we have Author (which will display the Created by Alias if defined in the article, otherwise it displays the Created by user), but in Ordering Options we have Alias, which I'm assuming would function in a similar way...ordering by either Created by or Created by Alias. Should these be labeled the same, either Author or Alias, to be consistent?

Finish Publishing Date

In Ordering Options we have the option to order by Finish Publishing Date but there is no display option for the finish publishing date. Should there be?

avatar drmenzelit
drmenzelit - comment - 28 Aug 2024

@JeffOnWire I think there is a misunderstanding of Alias ... Alias refers to the alias of the article, this one on the right:
grafik

avatar JeffOnWire
JeffOnWire - comment - 28 Aug 2024

@drmenzelit Ah, thank you.

avatar Hackwar
Hackwar - comment - 30 Aug 2024

Thank you @drmenzelit for this great feature!

avatar Hackwar Hackwar - close - 30 Aug 2024
avatar Hackwar Hackwar - merge - 30 Aug 2024
avatar Hackwar Hackwar - change - 30 Aug 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-30 19:58:41
Closed_By Hackwar
avatar Kostelano
Kostelano - comment - 16 Sep 2024

Sorry, so it doesn't get lost, I created #44088.

avatar drmenzelit
drmenzelit - comment - 16 Sep 2024

@Kostelano thank you for the hint, we removed some parameters on the last version of the module before the merge and it seems we forgot to chech this one. We will correct it.

Add a Comment

Login with GitHub to post a comment