RTC NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 May 2024

Since Joomla 5.0 we have shipped a version of tinyMCE that includes a plugin called accordion. However we never exposed it to our plugin so it was not available to use.

This PR remedies that.
New installs will see the accordion icon on the toolbar with the list icons For existing installs you will need to EITHER drag the icon into the toolbar in the plugin configuration OR if you havent changed the toolbar you can use the clear and the the use advanced preset buttons.

Technically tinymce have misnamed the the plugin as it should not be confused with other accordion functionality such as the js based solution that can be enabled with bootstrap.

This plugin implements the native html details/summary disclosure element which requires no javascript and is accessible out of the box.

To test

As this requires a js change either apply the pr and run nmp ci or use one of the prebuilt packages

If it is a new install then the icon will now be able in the toolbar. If it is an upgrade then you will need to use the tinymce plugin editor to add it (as described above)

Demo Usage

accordion

Notes

  1. It is a known issue in with tinymce that currently the only way to exit the accordion is to use the arrow keys to navigate out of the details/summary tinymce/tinymce#8890
  2. You can quickly create an accordion by highlighting a line of text and pressing the accordion button. This will convert the text into the details part

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 30 May 2024
avatar brianteeman brianteeman - change - 30 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2024
Category JavaScript Repository NPM Change Front End Plugins
96e6018 30 May 2024 avatar brianteeman cs
avatar brianteeman brianteeman - change - 30 May 2024
Labels Added: NPM Resource Changed PR-5.2-dev
avatar brianteeman brianteeman - change - 31 May 2024
The description was changed
avatar brianteeman brianteeman - edited - 31 May 2024
avatar brianteeman
brianteeman - comment - 31 May 2024

could someone please tag this as feature

avatar Fedik Fedik - test_item - 31 May 2024 - Tested successfully
avatar Fedik
Fedik - comment - 31 May 2024

I have tested this item ✅ successfully on ff21e79


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43577.

avatar viocassel viocassel - test_item - 31 May 2024 - Tested successfully
avatar viocassel
viocassel - comment - 31 May 2024

I have tested this item ✅ successfully on ff21e79


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43577.

avatar Quy Quy - change - 31 May 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 May 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43577.

avatar pe7er pe7er - change - 4 Jun 2024
Labels Added: RTC
avatar pe7er pe7er - change - 4 Jun 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-06-04 11:22:45
Closed_By pe7er
avatar pe7er pe7er - close - 4 Jun 2024
avatar pe7er pe7er - merge - 4 Jun 2024
avatar pe7er
pe7er - comment - 4 Jun 2024

Thanks @brianteeman !

Add a Comment

Login with GitHub to post a comment