[#43457] - [5.3] Add option for show/hide title in readmore
- Fixed in Code Base
- 16 Oct 2024
- Medium
- Build: 5.2-dev
- # 43457
- Diff
- rdeutz:readmore-off-title
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #34609 .
Summary of Changes
Adding an option to the newsflash module to show, hide use global setting for the text at the read more button
Testing Instructions
- Read the issue and confirm the issue on Joomla 5.2 with sample data
- apply patch
- go to the "Latest Posts" module
- change the "Read More with Title" options in the module and check if the hide/show have the effect we want
- change the "Read More with Title" options in the module to "Use global article settings"
- go to content -> options and change under articles the Read More with Title and check if the hide/show have the effect we want
Actual result BEFORE applying this Pull Request
See issue
Expected result AFTER applying this Pull Request
You can control from the newflash module what text is at the read more button in the newsflash module
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Modules Front End |
| Labels |
Added:
Language Change
PR-5.2-dev
|
||
I am bewildered. First you mention the «newsflash module». Later you ask «go to the "Latest Posts" module». I was unable to test thoroughly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.
Please test with the Articles - Newsflash module.
I have tested this item ✅ successfully on 0a2af87
Should be
3. go to the "Articles - Newsflash" module
NOT 3. go to the "Latest Posts" module
then the testing instructions are comprehensible. My tests were successful.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.
I have tested this item ✅ successfully on 0a2af87
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.
Hello,
tested, it does work ✅
I have tested it in a Multi language environment (FR/ENG)
All clear
Best
Phil
Hello, tested, it does work ✅ I have tested it in a Multi language environment (FR/ENG) All clear Best Phil
@pcombet-adosis Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43457 and mark your test result by using the blue "Test this" button at the top left corner, selecting your test result and finally submit, so that your test is properly counted. Just a comment with a green check mark is not enough. Thanks in advance.
I have tested this item ✅ successfully on 0a2af87
I have tested it in a Multi language environment (FR/ENG)
All clear
Best
Philippe
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.
I have tested this item ✅ successfully on 0a2af87
Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.
I have tested this item ✅ successfully on 0a2af87
Did what it says on the tin
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.
| Labels |
Added:
Updates Requested
|
||
| Category | Language & Strings Modules Front End | ⇒ | Modules Front End |
| Status | Pending | ⇒ | Ready to Commit |
As the last change after the successful human tests did just change the language string to the already existing global string, which is already used elsewhere in the same XML, which I've just checked by review, the previous human tests are still valid => RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.
| Labels |
Added:
RTC
Removed: Language Change Updates Requested |
||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
| Labels |
Added:
Feature
PR-5.3-dev
Removed: PR-5.2-dev |
||
drmenzelit
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-16 13:41:31 |
| Closed_By | ⇒ | drmenzelit |
I have not tested this item.
Not able to test, as instruction not clear. Where ist this module?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.