Unit/System Tests PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
11 May 2024

Pull Request for Issue #43441 .

Summary of Changes

delete an item on nested set table

Testing Instructions

run npm run cypress:run -- --spec 'tests/System/integration/api/com_menus/SiteMenuItems.cy.js'

Actual result BEFORE applying this Pull Request

fail

Expected result AFTER applying this Pull Request

success

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 11 May 2024
avatar alikon alikon - change - 11 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2024
Category JavaScript Unit Tests
avatar bembelimen
bembelimen - comment - 11 May 2024

I think we should really not use the "After" and "afterEach" event: https://docs.cypress.io/guides/references/best-practices#Using-after-Or-afterEach-Hooks

@laoneo

c7b39bc 12 May 2024 avatar alikon cs
avatar alikon alikon - change - 12 May 2024
Labels Added: Unit/System Tests PR-4.4-dev
1a9287b 12 May 2024 avatar alikon cs
1bb1eda 12 May 2024 avatar alikon cs
16a3001 12 May 2024 avatar alikon cs
edf1250 12 May 2024 avatar alikon drone
avatar alikon alikon - change - 18 May 2024
The description was changed
avatar alikon alikon - edited - 18 May 2024
avatar alikon
alikon - comment - 3 Jun 2024

still weird the drone failure

I would say "it works on my end" ?

avatar laoneo
laoneo - comment - 7 Jun 2024

What can be that the chaining I pointed out here can cause the issues as the task function does run async. Try my suggestion, perhaps it brings an improvement.

avatar alikon
alikon - comment - 8 Jun 2024

drone is happy now ?

a4c01e0 8 Jun 2024 avatar alikon cs
048af02 8 Jun 2024 avatar alikon cs
avatar laoneo
laoneo - comment - 12 Jun 2024

I'v restarted drone

avatar laoneo laoneo - change - 13 Jun 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-06-13 13:01:05
Closed_By laoneo
avatar laoneo laoneo - close - 13 Jun 2024
avatar laoneo laoneo - merge - 13 Jun 2024
avatar laoneo
laoneo - comment - 13 Jun 2024

Thanks!

Add a Comment

Login with GitHub to post a comment