[#43458] - [5.1] Installer manage: ignore clientid for plugin and library
- Closed
- 13 May 2024
- Medium
- Build: 5.1-dev
- # 43458
- Diff
- chmst:installer-manage-clientid
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Plugins and libraries are extensions independent from client_id.
It looks like a bug when filtering for Administrator Plugins is empty but Site plugins gives a complete set of Plugins.
We can ignore the type when filtering for these extensions.
Testing Instructions
Go to manage extensions, set filter to Administrator.
Filter for type plugins or libraries.
Actual result BEFORE applying this Pull Request
Result is empty
Expected result AFTER applying this Pull Request
Result is the same for type site and administrator
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Title |
|
||||||
I have tested this item ✅ successfully on 2ecee24
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43458.
Tried also PR on J 4.4.4 as issue also affects J 4.4 (= OK)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43458.
| Labels |
Added:
PR-5.1-dev
|
||
@chmst Other question (I haven't tested it myself): Is it sill possible to set a filter on the client_id for libraries and plugins with this PR? If yes, then it might be confusing some 50% if the users when they have set that filter and it is not really applied because the client_id is ignored. The other 50% of the users may be confused by how it is now without this PR and may favour this PR.
So either with or without this PR some users might be confused.
If that is the case that the filter still can be selected for libraries and plugins with this PR, then I think we should discuss it in the weekly maintainers meeting.
Thx for the hint. I restored the Tests.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43458.
| Status | Pending | ⇒ | Ready to Commit |
RTC as it has 2 successful human tests ... but I think we should discuss this PR in the weekly CMS maintainers meetings due to reasons stated in my previous comment, so I also set the RMDQ (release managers decision queue) label.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43458.
I have tested this item ? unsuccessfully on c214409
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43458.
It looks like a bug when filtering for Administrator Plugins is empty but Site plugins gives a complete set of Plugins.
It also looks like a bug when Filtering for API Plugins and you get a complete set of plugins which is what this PR produces. I "get" the problem this PR is trying to solve but the way it is done does not solve it,
Without PR
With PR
If you insist on going down the path of "ignoring" the location when the type is Plugin or Package then you should also start to "ignore" the folder when the Type is anything other than plugin
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to unsuccessful test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43458.
The filter is messy but nobody cares since years so it is not worth a discussion. Closing.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-13 11:00:45 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
RMDQ
|
||
I have tested this item ✅ successfully on 2ecee24
I have tested this successfully @chmst :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43458.