[#43400] - Fix System test com_privacy consent (#42523)
- Fixed in Code Base
- 30 Apr 2024
- Medium
- Build: 4.4-dev
- # 43400
- Diff
- muhme:4.4-dev
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
After discussion with Alikon the fix is simple 10 milliseconds waiting time after changing sorting order. The five failures were reproducable in 4.4-dev and fixed and it is expected it works the same way for 5.1.
Pull Request for Issue #42523.
Summary of Changes
After selecting a new sorting order it is needed to wait for the POST request to be fullfilled.
This is simple possible by waiting 10 milliseconds. 1 millisecond was enough, but to be save,
10 milliseconds are used.
Testing Instructions
In system test environment with Cypress test e.g. headless:
npm run cypress:run -- --spec tests/System/integration/administrator/components/com_privacy/Consent.cy.js
Please consider this is a racing condition. On drone the test were ?always? successful.
Therefore test first the failure, then patch and test success.
Actual result BEFORE applying this Pull Request
5 of the 24 tests in the spec failed.
Expected result AFTER applying this Pull Request
All 24 tests in the spec are successful.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
I have tested this item ✅ successfully on f26ce42
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43400.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43400.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-30 08:20:35 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
Unit/System Tests
PR-4.4-dev
|
||
Thanks!
I have tested this item ✅ successfully on f26ce42
Conmfirmed bug (again)
Applied PR
Bug gone - Thank YOU!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43400.