[#43398] - [5.2] Smart Search: Fix URL with highlight query
- Fixed in Code Base
- 7 Nov 2024
- Medium
- Build: 5.2-dev
- # 43398
- Diff
- Hackwar:5.2-finder-highlight
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
When the route of an entry in Smart Search isn't a query string, the highlight feature actually can produce invalid URLs. This PR enforces these URLs to be correct.
Testing Instructions
Look at #43397, apply that patch and get the testing plugin. Index an RTF file and search in the frontend for this entry in the search. Click on the URL.
Actual result BEFORE applying this Pull Request
The URL looks something like /tolstoy.rtf&highlight=bunchofbase64gibberish and throws a 404 when clicked.
Expected result AFTER applying this Pull Request
The URL looks something like /tolstoy.rtf?highlight=bunchofbase64gibberish and does not throw a 404 when clicked.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
Feature
bug
PR-5.2-dev
|
||
I have tested this item ✅ successfully on a5bd855
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43398.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43398.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-07 14:21:56 |
| Closed_By | ⇒ | pe7er |
I have tested this item ✅ successfully on a5bd855
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43398.