[#43396] - [5.3] Deprecate HTMLHelper::script(), HTMLHelper::stylesheet(), extend lifetime for Document style/script methods
- Fixed in Code Base
- 11 Feb 2025
- Medium
- Build: 5.2-dev
- # 43396
- Diff
- Fedik:jhtml-script-style-deprecation
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Deprecate HTMLHelper::script(), HTMLHelper::stylesheet().
Extend lifetime for Document style/script methods, because they cannot be removed before HTMLHelper::script(), HTMLHelper::stylesheet().
Add a new method HTMLHelper::mediaPath(), because we still need to lookup for overides.
Kind of temporary solution, until someone will come up with improvements to our media override API.
Testing Instructions
Apply patch. Make sure all works as before.
Add media/templates/administrator/atum/css/user.css to atum template, and make sure it still works.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#379
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.2-dev
|
||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
I have tested this item ✅ successfully on 4dd7f9c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43396.
This needs documentation as well.
| Labels |
Added:
Feature
Documentation Required
PR-5.3-dev
Removed: PR-5.2-dev |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43396.
| Labels |
Added:
RTC
|
||
I'm not exactly happy with this change. It feels a bit like change for changes sake and this is so widely used, that I don't see us removing this in 7.0.
That is why it extended from joomla 6 to joomla 7.
Anyway, it is going to happen in 7 or 8 or any time later.
Since joomla 4 we have to use web asset manager.
@Fedik @HLeithner @Hackwar @laoneo could you please figure out a path forward? Some people are totally against HTMLHelper others not. Make up your mind and document the decision.
Some people are totally against HTMLHelper others not.
It will not go anytime soon. It is fine feature.
It does not need for js/css, but there still many other usefull helpers that just cannot be replaced.
This is absolutely fine to deprecate them as loading assets should be done since 4 through the asset manager and not anymore HTMLHelper.
I would go one step further and move it to the b/c plugin (option in the plugin to active this or disable it).
I would not risk in 5.x, while HTMLHelper::_('script') is possible to make work with the b/c plugin, some extensions still use it improperly, like HTMLHelper::script()
Of course with 6.0 not with 5.x sorry not to mention it.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-11 14:43:05 |
| Closed_By | ⇒ | laoneo |
Thanks!
I have tested this item ✅ successfully on 4dd7f9c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43396.