PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
28 Apr 2024

Pull Request for Issue # .

Summary of Changes

Deprecate HTMLHelper::script(), HTMLHelper::stylesheet().
Extend lifetime for Document style/script methods, because they cannot be removed before HTMLHelper::script(), HTMLHelper::stylesheet().

Add a new method HTMLHelper::mediaPath(), because we still need to lookup for overides.
Kind of temporary solution, until someone will come up with improvements to our media override API.

Testing Instructions

Apply patch. Make sure all works as before.

Add media/templates/administrator/atum/css/user.css to atum template, and make sure it still works.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: TBD
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 28 Apr 2024
avatar Fedik Fedik - change - 28 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2024
Category Libraries
avatar Fedik Fedik - change - 28 Apr 2024
Labels Added: PR-5.2-dev
avatar degobbis degobbis - test_item - 24 Aug 2024 - Tested successfully
avatar degobbis
degobbis - comment - 24 Aug 2024

I have tested this item ✅ successfully on 4dd7f9c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43396.

avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.2] Deprecate HTMLHelper::script(), HTMLHelper::stylesheet(), extend lifetime for Document style/script methods
[5.3] Deprecate HTMLHelper::script(), HTMLHelper::stylesheet(), extend lifetime for Document style/script methods
avatar HLeithner HLeithner - edited - 2 Sep 2024

Add a Comment

Login with GitHub to post a comment