Feature PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 Apr 2024

Summary of Changes

We are in the process of migrating away from the CMS filesystem package to use the framework version of it. This PR converts all instances where File::getExt() & stripExt() is used to use the framework version.

Testing Instructions

Codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 24 Apr 2024
avatar Hackwar Hackwar - change - 24 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2024
Category Administration com_media com_templates Libraries Front End Plugins
avatar Hackwar Hackwar - change - 25 Apr 2024
Labels Added: PR-5.2-dev
avatar HLeithner
HLeithner - comment - 25 Apr 2024

No testing instructions, touches several places of the test is untestable, better make prs for the same area and not per type.

avatar HLeithner HLeithner - change - 15 Jul 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-07-15 09:27:49
Closed_By HLeithner
Labels Added: Feature
avatar HLeithner HLeithner - close - 15 Jul 2024
avatar HLeithner HLeithner - merge - 15 Jul 2024
avatar HLeithner
HLeithner - comment - 15 Jul 2024

thanks, merged by code review, both functions are identical between framework and cms version of filesystem\File and no other usages found in the changed files for this classes.

Add a Comment

Login with GitHub to post a comment