[#43362] - [5.2] Refactor all instances of File to use framework
- Fixed in Code Base
- 26 Aug 2024
- Medium
- Build: 5.2-dev
- # 43362
- Diff
- Hackwar:5.2-filesystem-file
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
We are in the process of migrating away from the CMS filesystem package to use the framework version of it. This PR converts all remaining instances where File is used to use the framework version.
Testing Instructions
Test that you can install extensions and that you can update Joomla.
OR
Codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer com_joomlaupdate Libraries |
| Labels |
Added:
PR-5.2-dev
|
||
| Labels |
Added:
Feature
|
||
The problem is, that we are surpressing the error page by having debug mode disabled. And in API there is no error page.
that we are surpressing the error page by having debug mode disabled
Yes, but you still will not see error on screenshot, because response non 200.
And in API there is no error page.
hmhm, yea, that tricky
I have tested this item ✅ successfully on 16a0a1e
Installing and uninstalling works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362.
I have tested this item ✅ successfully on 16a0a1e
I was able to install 4-5 simple to large components and confirmed they worked and uninstalled them successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362.
| Labels |
Added:
RTC
Removed: Feature |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-26 10:28:43 |
| Closed_By | ⇒ | pe7er |
@Hackwar a hint for debuging, hack the ErroDocument, and set status 200
joomla-cms/libraries/src/Document/ErrorDocument.php
Line 122 in e2170c8
The thing that cypress always show blank page when the response code non 200.
This hack will force it to render joomla error page (unless it handled by Symfony error handler), and see them on screen shots in Artifacts.