PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 Apr 2024

Summary of Changes

We are in the process of migrating away from the CMS filesystem package to use the framework version of it. This PR converts all instances where File::delete() is used to use the framework version. In that process, all other calls to the CMS File class in that file were converted to properly handle possible exceptions from the framework equivalent. This intentionally did not add additional error handling. I expect that to be a separate effort in the future.

Testing Instructions

Codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 24 Apr 2024
avatar Hackwar Hackwar - change - 24 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2024
Category Libraries Front End Plugins
avatar Quy Quy - change - 25 Apr 2024
Labels Added: PR-5.2-dev
avatar laoneo laoneo - change - 13 Aug 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-13 13:39:01
Closed_By laoneo
avatar laoneo laoneo - close - 13 Aug 2024
avatar laoneo laoneo - merge - 13 Aug 2024

Add a Comment

Login with GitHub to post a comment