Feeling Lucky
PR-6.0-dev
PR-5.2-dev
[#43357] - [6.0] Custom Fields: Correcting typehint for $this in layout
- Fixed in Code Base
- 22 May 2024
- Medium
- Build: 5.2-dev
- # 43357
- Diff
- Hackwar:5.2-fields-this
User tests: Successful: Unsuccessful:
Summary of Changes
When adding typehints for these custom fields, I mistakenly used the FileLayout class, while it actually is the respective plugins class.
Testing Instructions
Codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
PR-5.2-dev
|
||
HLeithner
- comment
- 22 May 2024
yes, but didn't head the time yet
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-22 18:44:04 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
PR-6.0-dev
|
||
HLeithner
- comment
- 22 May 2024
Merged in 6.0 to prevent override notification system, thanks
| Title |
|
||||||
Hackwar
- comment
- 22 May 2024
Thank you!
@HLeithner could it be that we need to merge the 5.2-dev to 6.0-dev first?