[#43358] - [5.2] Adding missing properties to backend component view classes
- Fixed in Code Base
- 13 Aug 2024
- Medium
- Build: 5.2-dev
- # 43358
- Diff
- Hackwar:5.2-undefined-property-1
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
These are missing properties used by our layouts in the backend component view classes.
Testing Instructions
Codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_categories com_checkin com_config com_contact com_content com_finder com_menus com_modules com_newsfeeds com_plugins com_tags com_templates com_users com_workflow |
| Labels |
Added:
PR-5.2-dev
|
||
I would merge it to have to properties defined, maybe adding a note to change the base class with 6
In the meantime I tried using the FormView class instead and it would require major refactoring, which is out of the scope of this PR. Simply switching the base class and removing the properties does not work. Since this PR changes 19 files, this would mean hundreds of complex changes to those 19 files and is not testable anymore. We should be looking at refactoring this accordingly in other PRs, but for this PR it would be out of scope.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-13 11:34:40 |
| Closed_By | ⇒ | laoneo |
Thanks!
I didn't want to change the base class.