[#43356] - [5.2] Installation: Move getOptions() in models to base class
- Fixed in Code Base
- 13 Aug 2024
- Medium
- Build: 5.2-dev
- # 43356
- Diff
- Hackwar:5.2-installation-getoptions
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
While running phpstan, it threw notices for the ChecksModel and SetupModel versions of getOptions(), since they didn't have proper return statements. Looking at the other models, the code was more complex than necessary. Then also looking at the other models, it is unnecessary to have the same method 4 times in classes inheriting from the same base class, so this PR moves that method to the base class.
Testing Instructions
Simply run through the installation of Joomla after this change and nothing should be different to before. So realistically this is a matter of codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Labels |
Added:
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-13 09:33:24 |
| Closed_By | ⇒ | laoneo |
Thanks!