Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#43336] - [4.4] [bug] Media manager misbehaves on files with capitalized extensions

RTC NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
23 Apr 2024

Pull Request for Issue #43315 .

Summary of Changes

  • Fix the logic

Testing Instructions

Note that you have to copy the file, Media Manager always normalizes extensions to lowercase!!!

  • Copy a file with a capitalized extension
  • Try to edit -> rotate -> save

Actual result BEFORE applying this Pull Request

File is not saved

Expected result AFTER applying this Pull Request

File is saved

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

baa351c 23 Apr 2024 avatar dgrammatiko a
b5c1d7d 23 Apr 2024 avatar dgrammatiko b
avatar dgrammatiko dgrammatiko - open - 23 Apr 2024
avatar dgrammatiko dgrammatiko - change - 23 Apr 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2024
Category ⇒ JavaScript Repository NPM Change Libraries
avatar Quy
Quy - comment - 23 Apr 2024

Missing this change:

joomla-cms/plugins/filesystem/local/src/Adapter/LocalAdapter.php

Line 824 in 1c79063

$tmpFile = Path::clean(\dirname($localPath) . '/' . uniqid() . '.' . strtolower(File::getExt($name)));

Then the other PR can be closed as this will be upmerged. Thanks.

avatar dgrammatiko dgrammatiko - change - 23 Apr 2024
Labels Added: NPM Resource Changed PR-4.4-dev
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2024
Category JavaScript Repository NPM Change Libraries ⇒ JavaScript Repository NPM Change Libraries Front End Plugins
avatar HLeithner HLeithner - change - 24 Apr 2024
Title
…
[4.4][bug] Media manager misbehaves on files with capitalized extensions
[4.4] [bug] Media manager misbehaves on files with capitalized extensions
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar Quy Quy - test_item - 26 Apr 2024 - Tested successfully
avatar Quy
Quy - comment - 26 Apr 2024

I have tested this item ✅ successfully on 2e448dc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43336.

avatar alikon alikon - test_item - 26 Apr 2024 - Tested successfully
avatar alikon
alikon - comment - 26 Apr 2024

I have tested this item ✅ successfully on 2e448dc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43336.

avatar alikon alikon - change - 26 Apr 2024
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 26 Apr 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43336.

avatar MacJoom MacJoom - change - 26 Apr 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-04-26 14:10:30
Closed_By ⇒ MacJoom
Labels Added: RTC
avatar MacJoom MacJoom - close - 26 Apr 2024
avatar MacJoom MacJoom - merge - 26 Apr 2024
avatar MacJoom
MacJoom - comment - 26 Apr 2024

Thank you!

Add a Comment

Login with GitHub to post a comment