[#43335] - [4.4] Fix ordering for files in the template view
- Fixed in Code Base
- 8 May 2024
- Medium
- Build: 4.4-dev
- # 43335
- Diff
- HLeithner:4.4/fix/template-file-ordering
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #40605 .
Summary of Changes
Order is now using the right values for displaying directory structure for templates in the backend.
This could happen on posix filesystems because the natural order is the file creation and not the alphabetical order.
Testing Instructions
Check if your directories and files are sorted in the corrected order
Actual result BEFORE applying this Pull Request
The order was only for directories correct
Expected result AFTER applying this Pull Request
Sorting happens in the model and not longer in the view for directories and files.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Additional
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Labels |
Added:
PR-4.4-dev
|
||
Is the image a before or after. If after then it is showing the folders in the tree not being in alphabetical order
I think so, I didn't see much changes since 4.4 in 5.1
I have tested this item ✅ successfully on f3a8732
I successfully tested the PR on a J5.1.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43335.
Is the image a before or after. If after then it is showing the folders in the tree not being in alphabetical order
correct php fooled me and the over complicated php code didn't make it better. I updated the code and moved from uasort to uksort. Now it works as expected.
Here the image from joomla 5.1:
Now I am really confused. The original PR used uasort and did not work with cassiopeia. Yet @dautrich says it does work with the j51 template
it partly works with cassiopeia as you pointed out based on the image (media folder -> images shouldn't be on the last place, btw. this information in you comment would have saved me 10 minutes...). so his test is wrong.
Template Skylar
@HLeithner
Do you want me to re-test this?
@HLeithner Do you want me to re-test this?
Plz
I have tested this item ✅ successfully on 4edaa4c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43335.
@HLeithner
Would you like me to test this patch on J5.1.0 as well, or will you provide a separate PR for J5.1.0?
@HLeithner Would you like me to test this patch on J5.1.0 as well, or will you provide a separate PR for J5.1.0?
Will be upmerged so no test/PR for 5.1 needed thankd
I have tested this item ✅ successfully on 4edaa4c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43335.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43335.
| Labels |
Added:
RTC
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-08 07:36:38 |
| Closed_By | ⇒ | MacJoom |
Thank you!
@HLeithner
The fix is for J4, isn't it? Can I apply the patch to J5.1 as well?